Aggregator block: Display the more link only if there are items present [#68156]

Comment	File	Size	Author
#4	aggregator_empty_block.patch.txt	2.44 KB	Heine
#2	aggregator_more_link.patch	2.52 KB	Zen

	aggregator_3.patch	2.3 KB	Zen

Comment #1

beginner CreditAttribution: beginner commented 8 August 2006 at 14:02

Version:	4.7.2	» x.y.z
Status:	Needs review	» Needs work

+1 generally on the patch, but:

1) $read_more is not initialized and will create a Notice error when there is no more feeds to read.
2) cvs has this bug, too, and should be fixed first so that we are sure we won't forget to include the fix in the next version :)
3) diff from the root: http://drupal.org/patch

Log in or register to post comments

Comment #2

Zen CreditAttribution: Zen commented 31 October 2006 at 23:28

Status:

Needs work

» Needs review

File	Size
aggregator_more_link.patch	2.52 KB

Thanks for the review. Updated.

This patch also updates the title of the anchor tag to display a more relevant message.

-K

Log in or register to post comments

Comment #3

Zen CreditAttribution: Zen commented 31 October 2006 at 23:29

Version:

x.y.z

» 4.7.4

This patch is against 4-7-4.

-K

Log in or register to post comments

Comment #4

Heine CreditAttribution: Heine commented 27 November 2006 at 08:44

Version:

4.7.4

» 5.x-dev

File	Size
aggregator_empty_block.patch.txt	2.44 KB

Rolled a patch before I saw this issue, so you're not the only one considering this a minor bug.

Here's a patch against 5-dev.

$type will be either feed or category, so $read_more will be defined (as will $result). Text change is for another patch.

Code comment may be obvious.

Log in or register to post comments

Comment #5

bdragon CreditAttribution: bdragon commented 27 November 2006 at 22:33

Status:

Needs review

» Reviewed & tested by the community

A side effect of having an empty block content is that such blocks will disappear from the layout.

This is a behavioral change, but one that I believe is more in line with the way the rest of Drupal works (i.e. if it isn't relevant, it isn't shown.)

All that being said, patch in #4 looks OK to me, works as advertised, and doesn't break anything. RTBC.