This will allow re-using of _options_properties() when type doesn't exist, thus preventing a WSOD.

CommentFileSizeAuthor
#2 _options_properties-init-value-1.patch440 bytesamitaibu
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

aspilicious’s picture

aspilicious CreditAttribution: aspilicious commented

Forgot patch?

amitaibu’s picture

amitaibu
Primary language Hebrew
Location Israel
CreditAttribution: amitaibu commented
FileSize
_options_properties-init-value-1.patch440 bytes

oops :)

yched’s picture

yched CreditAttribution: yched commented
Status: Needs review » Reviewed & tested by the community

I'm not sure I see the use case of "reusing _options_properties() when type doesn't exist", but the change is good coding practice anyway, so RTBC.

webchick’s picture

webchick
she/they
Primary language English
Location Vancouver 🇨🇦
CreditAttribution: webchick commented
Status: Reviewed & tested by the community » Fixed

Committed to HEAD, thanks!

amitaibu’s picture

amitaibu
Primary language Hebrew
Location Israel
CreditAttribution: amitaibu commented

thanks,

@yched,
Just to clearify - the OG field #type changes according to existing values. So if there are no existing groups then #type = 'item'. otherwise, OG passes the correct type to _options_properties().

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.