Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
This might've been a side-effect of #563390: Seven theme lacks formatting on common html elements such as lists, paragraphs & <code>:
Comment | File | Size | Author |
---|---|---|---|
#5 | 679096.patch | 474 bytes | EclipseGc |
#4 | bad_layout.png | 10.37 KB | aspilicious |
#3 | bad_layout.png | 3.1 KB | aspilicious |
Comments
Comment #1
mrfelton CreditAttribution: mrfelton commentedYes, I believe this was caused by my patch. Should dashboard.module should provide it's own css for this special case, or should the fix should be included in the main style.css?
EDIT: dashboard module already has it's own css, so I'll add a fix to that Just need to remove the margin from those h2s I think
Comment #2
webchickWell. Be careful about fixing it in dashboard.css. That takes effect for *all* themes.
Comment #3
aspilicious CreditAttribution: aspilicious commentedNot done with this ;)
See attachment!
Comment #4
aspilicious CreditAttribution: aspilicious commentedOooor this one...
Comment #5
EclipseGc CreditAttribution: EclipseGc commentedHere's a fix for the seven theme.
Comment #6
EclipseGc CreditAttribution: EclipseGc commentedComment #7
aspilicious CreditAttribution: aspilicious commentedThis only fix the first issue do i need te open 2 different issues for my problems?
Comment #8
EclipseGc CreditAttribution: EclipseGc commented@ aspilicious:
Yeah, it's kind of frowned upon when you try to hijack one issue to fix other problems. I don't understand what's the matter with the second screen shot, but I have 2 potential fixes for the first. Post a link to that issue here for me, and I'll try to weigh in on it and get you a fix.
Comment #9
webchickAwesome, thanks! I confirm this fixes the bug. Committed to HEAD. :D
@aspilicious: If there are a lot of follow-up fixes for the old patch, let's re-open the other issue. I just wanted to get this one out of the way since it's definitely wrong and we have an alpha next week omg omg omg.
Comment #10
aspilicious CreditAttribution: aspilicious commentedin the second picture look at the black dot in the middle of the circle but i think they (1 and 2) are related.
We will start with the first one...
==> #679326: Dragging "User menu" block into Dashboard looks oooglay
Comment #11
casey CreditAttribution: casey commentedBoth issues aspilicious mentions are fixed elsewhere.