Tab titles on Trigger page are not clear

I am not sure if this is truly a bug, our goal is indeed to avoid useage of Node - however it is a goal, whenever the context says us to do different we most definitely should. The trigger UI in that sense, to me applies to a different context - which is of building relationship models of objects (Content item ID) would be one to go for, however it is technically incorrect to call this tab Content (as it would house the object, comment to).

Hmm, this is hard. I am not sure, hope someone else will chime in.

Looks good, RTBC

#8: 678606fix.patch queued for re-testing.

here's the .rej I get when I try to apply this patch:

***************
*** 619,621 ****
    return $triggers;
  }

--- 607,639 ----
    return $triggers;
  }

+ /**
+  * Gathers information about tabs on the triggers administration screen.
+  *
+  * @return
+  *    Array of modules that have triggers, with the keys being the
+  *    machine-readable name of the module, and the values being the
+  *    human-readable name of the module.
+  */
+ function _trigger_tab_information() {
+
+   // Gather the trigger information.
+   $trigger_info = module_invoke_all('trigger_info');
+   drupal_alter('trigger_info', $trigger_info);
+
+   $return_info = array();
+   foreach ($trigger_info as $module => $hooks) {
+     $info = db_select('system')
+       ->fields('system', array('info'))
+       ->condition('name', $module)
+       ->condition('status', 1)
+       ->execute()
+       ->fetchField();
+     if ($info) {
+       $info = unserialize($info);
+       $return_info[$module] = $info['name'];
+     }
+   }
+
+   return $return_info;
+ }

Marked as duplicate #659838: trigger help for system group is not generic.

Also menu related #544318: Rework trigger_menu()

Why not use system_list() against querying database?

Re-roll, fixed indent in hook_help()

_trigger_tab_information() now uses API to get triggers and modules info

Fixed indent for doc-block

I think better to query only modules that have triggers because this lead to less memory consumption

Main difference that my patch uses only 1 query and a bit indent fixes.

Screens are looks the same except a link at the bottom of help text

This also a performance improvement because 5 queries are going to be 1 in hook_menu()

Also we need seting for MENU_DEFAULT_LOCAL_TASK as proposed in #544318-12: Rework trigger_menu()

Current implementation make a query per each module that defines hook_trigger_info()
You could see foreach() loop with db_select() inside http://api.drupal.org/api/function/trigger_menu/7

We cannot do that.

1. It's really not a performance improvement, as hook_menu() is only called when regenerating the menu
2. Just call system_get_info() here, instead of trying to write a SQL query by yourself

Re-roll with system_get_info()

#28: 678606-trigger-menu-d7.patch queued for re-testing.

Well, that's certainly... interesting... code there to work around this bug. :) Oh, Trigger module...

I spoke with Jennifer about this in IRC. Unlike #690622: Word "node" is still being used all over Drupal 7... where the word "node" is clearly appearing in human-facing sentences where it ought not to be, this one is a bit more borderline:

+  foreach ($trigger_info as $module => $module_name) {
+    $items["admin/structure/trigger/$module"] = array(
+      'title' => $module_name,

We actually do want the module name there, which is Node. "Content" module is a different thing. Unlike those other strings, this is a site-builder/developer-hybrid facing page.

But even aside from those general misgivings, the patch includes this hunk:

-  // We want contributed modules to be able to describe
-  // their hooks and have actions assignable to them.
-  $trigger_info = module_invoke_all('trigger_info');
-  drupal_alter('trigger_info', $trigger_info);

...with no corresponding + hunks. I'm sure it's not intentional to remove this hook (if it was, we should remove the trigger.api.php reference, too), so this doesn't quite pass my RTBC smell test.

So rather than trying to rush this in when it's already somewhat borderline, I'm going to kick this to D8. Jennifer seemed cool with it in IRC too, stating that people should just be using Rules anyway. :D

+1 for d7, there's no api changes and introduced strings cleanup just make a translators job a bit easy

Oh, ok. Upon actually testing it, I can see that it doesn't change the "Node" title at all, and it is indeed just internal re-organization of some stuff and getting rid of a bunch of almost-duplicate strings.

I still think this looks a little funny, but on the other hand it's "just" Trigger module, so is unlikely to seriously hurt anyone.

Committed to HEAD. Thanks!