Minor optimization suggested for menu.inc [#67434]

Currently, _menu_append_contextual_items() starts like:

foreach ($menu_item_list as $item) {
    if (isset($item['callback'])) {
      $_menu['callbacks'][$item['path']] = array('callback' => $item['callback']);
      if (isset($item['callback arguments'])) {
        $_menu['callbacks'][$item['path']]['callback arguments'] = $item['callback arguments'];
      }
  unset($item['callback arguments']);
  unset($item['callback']);

However, it doesn't seem useful to unset these variables if they're not set. Hence a potential minor optimization avoids this useless code:

foreach ($menu_item_list as $item) {
    if (isset($item['callback'])) {
      $_menu['callbacks'][$item['path']] = array('callback' => $item['callback']);
      if (isset($item['callback arguments'])) {
        $_menu['callbacks'][$item['path']]['callback arguments'] = $item['callback arguments'];
        unset($item['callback arguments']);
      unset($item['callback']);
      }

The same seems to apply in _menu_build. The suggested patch modifies both.

Comment	File	Size	Author
#4	menu.inc_9.patch	1.36 KB	fgm
#4
	menu.inc_8.patch	1.3 KB	fgm

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Comment #1

fgm

French

Paris, France

CreditAttribution: fgm commented 5 June 2006 at 21:52

Status:

Active

» Needs review

(forgot to set status)

Comment #2

Dries CreditAttribution: Dries commented 6 June 2006 at 14:40

The spaces look wrong? Did you properly intend the code (no tabs)? Otherwise looks good. :)

Comment #3

chx CreditAttribution: chx commented 6 June 2006 at 14:54

Title:

Minor optimization suggested for form.inc

» Minor optimization suggested for menu.inc

Comment #4

fgm

French

Paris, France

CreditAttribution: fgm commented 6 June 2006 at 18:59

File	Size
menu.inc_9.patch	1.36 KB

Indeed, incorrect explanation. Here is the fix, with the missing closing brace reinstated:

  foreach ($menu_item_list as $item) {
    if (isset($item['callback'])) {
      $_menu['callbacks'][$item['path']] = array('callback' => $item['callback']);
      if (isset($item['callback arguments'])) {
        $_menu['callbacks'][$item['path']]['callback arguments'] = $item['callback arguments'];
      unset($item['callback arguments']);
      }
    unset($item['callback']);
    }

Patch rerolled just to be sure.

Comment #5

fgm

French

Paris, France

CreditAttribution: fgm commented 6 June 2006 at 19:00

And, someday, I won't miss the core indenting conventions:

  foreach ($menu_item_list as $item) {
    if (isset($item['callback'])) {
      $_menu['callbacks'][$item['path']] = array('callback' => $item['callback']);
      if (isset($item['callback arguments'])) {
        $_menu['callbacks'][$item['path']]['callback arguments'] = $item['callback arguments'];
        unset($item['callback arguments']);
      }
      unset($item['callback']);
    }