Support HTTP auth method in settings [#669456]

Currently only the username and password fields are provided in the settings. Since basic and digest are fairly common it should support the ability to switch between them easily.

Comment	File	Size	Author
#5	669456-http-auth-method.patch	4.33 KB	boombatower
#5
#3	669456-http-auth-method.patch	3.36 KB	boombatower
#3
#2	669456-http-auth-method.patch	5.77 KB	boombatower
#2
#1	669456-http-auth-method.patch	5.79 KB	boombatower
#1

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Comment #1

boombatower CreditAttribution: boombatower commented 28 December 2009 at 21:40

Assigned:	Unassigned	» boombatower
Status:	Active	» Needs review

File	Size
669456-http-auth-method.patch	5.79 KB

Comment #2

boombatower CreditAttribution: boombatower commented 28 December 2009 at 21:42

File	Size
669456-http-auth-method.patch	5.77 KB

Hmmm, that patch was messed up.

Comment #3

boombatower CreditAttribution: boombatower commented 28 December 2009 at 21:43

File	Size
669456-http-auth-method.patch	3.36 KB

Double fail.

Comment #4

Dave Reid

he/him

English

Nebraska USA

CreditAttribution: Dave Reid commented 29 December 2009 at 21:26

+++ modules/simpletest/drupal_web_test_case.php	28 Dec 2009 21:42:50 -0000
@@ -415,6 +415,7 @@
+    $this->httpauth_method = variable_get('simpletest_method', CURLAUTH_BASIC);

Would seem to make more sense to have this variable's name be simpletest_httpauth_method. Little longer, but self-documenting.

+++ modules/simpletest/simpletest.pages.inc	28 Dec 2009 21:42:50 -0000
@@ -442,8 +442,23 @@
+    '#options' => array(
+      CURLAUTH_BASIC => t('Basic'),
+      CURLAUTH_DIGEST => t('Digest'),
+      CURLAUTH_GSSNEGOTIATE => t('GSS negotiate'),
+      CURLAUTH_NTLM => t('NTLM'),
+      CURLAUTH_ANY => t('Any'),
+      CURLAUTH_ANYSAFE => t('Any safe'),
+    ),

Do we need to explain these values at all or the fact that Any and the Any safe options are catch-all options?

This review is powered by Dreditor.

Comment #5

boombatower CreditAttribution: boombatower commented 29 December 2009 at 21:58

File	Size
669456-http-auth-method.patch	4.33 KB

Decided that this is dev setting, so we can assume they know them or can look them up and don't need/want to clutter this.

Renamed all related variables to httpauth_.

Comment #6

Dave Reid

he/him

English

Nebraska USA

CreditAttribution: Dave Reid commented 29 December 2009 at 22:18

Status:

Needs review

» Reviewed & tested by the community

Looks good. Upgrade path isn't necessary since this is a 'new' module (although we should put one in the 6.x-2.x backport).

Comment #7

Dries CreditAttribution: Dries commented 30 December 2009 at 11:42

Status:

Reviewed & tested by the community

» Fixed

Committed to CVS HEAD. Thanks boombatower.

Comment #8

cburschka

they

CreditAttribution: cburschka commented 30 December 2009 at 13:49

In order to be able to use this in all PHP environments, it would be helpful if this patch could be looked at: #670454: Support HTTP Authorization in CGI environment. :-)