Regression: RSS feed enclosure support lost from core

subscribing

#1: enclosure.patch queued for re-testing.

subscribe

Suppose view-mode should be inherited from entity to field. What rss-formatter means while entity viewed in search-resulot mode?

Seems like a bug (regression) to me.

Fixing the priority.

Since there's a contrib workaround, demoting to normal.

Working on a reroll and test for this.

Component change is due to a d.o bug; we can change it back once file.module exists again. :)

Re-rolled patch for git against d8, which probably wont work as $object doenst exist? investigating..

New patch attached which uses $entity, which now formats the RSS properly. working on tests...

Uploading new patch, which includes a test, to test that the RSS enclosure is displayed properly inside the RSS feed.

Uploading separate patch file, with just the test in it.

The test is green. Does this mean that the test is incorrect or that the bug is gone in d8?

Thanks for the reroll and the tests tayzlor. I haven't looked at why the test without the patch is green, as aspilicious alluded to in #25, but in the mean time, here's some minor cleanups:

+++ b/core/core/modules/file/lib/Drupal/file/Tests/FileFieldRSSContentTest.php
@@ -0,0 +1,78 @@
+    ¶

remove trailing whitespace.

+++ b/core/core/modules/file/lib/Drupal/file/Tests/FileFieldRSSContentTest.php
@@ -0,0 +1,78 @@
+    ¶

remove trailing whitespace.

+++ b/core/core/modules/file/lib/Drupal/file/Tests/FileFieldRSSContentTest.php
@@ -0,0 +1,78 @@
+    ¶

remove trailing whitespace.

Thanks @tayzlor and @disasm.

Here's a couple other code style cleanups for the patch:

+++ b/core/core/modules/file/lib/Drupal/file/Tests/FileFieldRSSContentTest.phpundefined
@@ -0,0 +1,78 @@
+    // Create a new node with a file field set. Promote to frontpage needs to be set
+    // so this node will appear in the RSS feed.

This comment also needs to wrap sooner; it's over 80 characters.

+++ b/core/core/modules/file/lib/Drupal/file/Tests/FileFieldRSSContentTest.phpundefined
@@ -0,0 +1,78 @@
+    $this->assertRaw(format_xml_elements(array($test_element)), 'File field RSS enclosure is displayed when viewing the rss feed.');

RSS should also be capitalized both places here.

Next we need to figure out why the test isn't failing. Tagging for manual testing to determine how the existing patch affects the feed. Let's also clearly document the steps to reproduce this issue, including samples of the before-and-after markup for the feed, and add this information to an issue summary.

Also correcting the component now that the list is fixed.

Here i correct code style cleanups for the patch #23

Thanks,
Jaffar

Here i corrected code style cleanups for the patch #26 and #27

Thanks,
Jaffar

Reapplied patch #28 and made a test only version it. As 29 is broken.
Also included in post original patch from #28.

Thanks iflista for getting these patches organized. I think we can finally say with certainty that the problem exists, the test detects it, and the patch fixes it. One minor word change in a doc string and I'll RTBC this.

+++ b/core/modules/file/lib/Drupal/file/Tests/FileFieldRSSContentTest.php
@@ -0,0 +1,78 @@
+   * Tests RSS encloser formatter display for RSS feeds.

enclosure, not encloser

+++ b/core/modules/file/lib/Drupal/file/Tests/FileFieldRSSContentTest.phpundefined
@@ -0,0 +1,78 @@
+    // Check that the rss enclosure appears in the RSS feed.

Let's also clean this up so that RSS is uppercase both times.

Nice work!

Cleaned up things due to comments.
New patches with interdiffs are attached below.

Following Issue Summary Template standards http://drupal.org/node/1155816

Tested on a fresh drupal 8 install, without patch - no way to add enclosure element.

Patched applied and tested manually - works as the steps in the Issue Description

Here's a dump from RSS.xml :)

<?xml version="1.0" encoding="utf-8"?>
<rss version="2.0" xml:base="http://dev.willskills.com/drupal"  xmlns:dc="http://purl.org/dc/elements/1.1/">
<channel>
 <title>d8</title>
 <link>http://dev.willskills.com/drupal</link>
 <description>dev.drupal8</description>
 <language>en</language>
<item>
 <title>Test Test</title>
 <link>http://dev.willskills.com/drupal/node/1</link>
 <description>&lt;div  class=&quot;field field-name-body field-type-text-with-summary field-label-hidden&quot;&gt;&lt;div class=&quot;field-items&quot;&gt;&lt;div class=&quot;field-item even&quot; property=&quot;content:encoded&quot;&gt;&lt;p&gt;Teeeeeeeeeeeeeeeeeest&lt;/p&gt;
&lt;/div&gt;&lt;/div&gt;&lt;/div&gt;</description>
 <pubDate>Wed, 10 Oct 2012 16:48:31 +0000</pubDate>
 <dc:creator>willwh</dc:creator>
 <guid isPermaLink="false">1 at http://dev.willskills.com/drupal</guid>
 <enclosure url="http://dev.willskills.com/drupal/sites/default/files/woof.txt" length="20" type="text/plain" />
 <comments>http://dev.willskills.com/drupal/node/1#comments</comments>
</item>
</channel>
</rss>

Issue Summary Template standards

http://drupal.org/node/1155816 - Issue Summary Template standards

Thanks @willwh!

One last update per disasm / zendoodles

The STR in the summary didn't quite tell me the whole story, so here's what I did to test this:

1. Install Drupal 8 with the standard profile.
2. At admin/structure/types/manage/article, add a file field.
3. Create a new article at node/add/article and upload a file in the file field.
4. Visit rss.xml. A plain link to the file is present.
   
5. At admin/structure/types/manage/article/display, under Custom display settings, check the box for "RSS" to try to customize the display and save.
6. Go to admin/structure/types/manage/article/display/rss and attempt to customize the display of the file field for the RSS view mode. There is no way to customize the output to use an enclosure.
7. Apply the patch from #33.
8. Clear the site cache at admin/config/development/performance. There's now an RSS enclosure option. Select that and save.
   
9. Visit rss.xml again. The file now is rendered in an enclosure.
   

Updated issue summary.

Updated the summary with some more complete STR and the sample output from @willwh.

Updated issue summary.

Updated issue summary.

Updated issue summary.

This looks good to me.

Me too! Thanks for the fix, and the tests. :)

Committed and pushed to 8.x.

Oopsie.

And no idea why that tag got removed. d.o has been a bit funky lately.

I think a followup feature request to extend the formatter to image fields would be worthwhile.

The same fix applies to Drupal 7 as well, I'm attaching the patch.
I'll try to backport the tests.

I'm attaching the patch, and now tests are included.

I think tests are OK, failed in #35 too.

The failure in #35 was from the test-only patch that does not include the bugfix, so it was expected that it would fail. #47 is supposed to be a complete patch including the fix, so the fact that the test is failing is a problem. I'd suggest testing the patch manually and also running the test locally to determine why it is failing.

#33: rss-feed-enclosure-666412-33.patch queued for re-testing.

@netol, if you click the "view details" link next to the patch, it shows that the failure is:
File field RSS enclosure is displayed when viewing the RSS feed.

This isn't a random failure that will go away with a retest; it's a part of this issue. So either the patch does not actually work, or the code of the test is bugged. So, some local testing and debugging should be done to determine which it is. Thanks everyone!

Yes, I'm looking at it right now. Thanks.

The test passed in my machine (the day that uploaded the patch, and today). I've also checked the output of the test manually, and:

<?xml version="1.0" encoding="utf-8"?>
<rss version="2.0" xml:base="http://localhost/git/drupal"  xmlns:dc="http://purl.org/dc/elements/1.1/">
<channel>
 <title>Drupal</title>
 <link>http://localhost/git/drupal</link>
 <description></description>
 <language>en</language>
<item>
 <title>wVxZTRlX</title>
 <link>http://localhost/git/drupal/node/1</link>
 <description>&lt;div class=&quot;field field-name-body field-type-text-with-summary field-label-hidden&quot;&gt;&lt;div class=&quot;field-items&quot;&gt;&lt;div class=&quot;field-item even&quot; property=&quot;content:encoded&quot;&gt;&lt;p&gt;tAPewfvhIkj6qmtzxU4CDsRwAIEFoK7q&lt;/p&gt;
&lt;/div&gt;&lt;/div&gt;&lt;/div&gt;</description>
 <pubDate>Fri, 02 Nov 2012 22:25:11 +0000</pubDate>
 <dc:creator>kKo8G61i</dc:creator>
 <guid isPermaLink="false">1 at http://localhost/git/drupal</guid>
 <enclosure url="http://localhost/git/drupal/sites/default/files/simpletest/523225/text-0_0.txt" length="1024" type="text/plain" />
 <comments>http://localhost/git/drupal/node/1#comments</comments>
</item>
</channel>
</rss>

includes:

<enclosure url="http://localhost/git/drupal/sites/default/files/simpletest/523225/text-0_0.txt" length="1024" type="text/plain" />

So I don't see why assertRaw() fails in http://qa.drupal.org/
How can I run exactly the same tests that qa.drupal.org is running?

@netol, the tests that qa.drupal.org is running are the tests included in Drupal core, and the one that is failing is the one included in the patch you created. To run them locally, enable the testing module and go to admin/config/development/testing. All the tests in the test suite are listed there. See http://drupal.org/node/519364 for more information.

Thanks for your support, but I've run the same test multiple times. I did it before uploading the patch. I'm attaching screenshots...

My question is, why the same test passes successfully in my machine and not in qa.drupal.org ?

It's obvious that I'm doing something wrong, but I can't see what.

Updated issue summary.

This was committed back in #42. In #43, it was moved to patch to be ported. It was not ported in the past 4 years.

Also, since then, we've changed the policy for this: if this should be backported to Drupal 7, it'll need a separate issue.

So, moving back to #42's issue state.

Way back in comment 45, xjm said

I think a followup feature request to extend the formatter to image fields would be worthwhile.

I don't see any follow-up, and the functionality is still missing, so I've raised #3150318: Support image fields in RSS enclosure formatter :-) Sorry to update such an old issue but I figure anyone investigating this might find themselves here, just as I did.