Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.In our ongoing mission to improve Drupals performance by removing bits of text from the interface we have found another candidate :-) The maintanance mode admin screen has some room for improvements.
| Comment | File | Size | Author |
|---|---|---|---|
| #27 | maintenance-mode-666170-27.patch | 3.04 KB | drupal_was_my_past |
| #22 | 666170d.patch | 2.94 KB | lisarex |
| #18 | 666170c.patch | 2.94 KB | lisarex |
| #14 | 666170b.png | 59.47 KB | lisarex |
| #14 | 666170b.patch | 2.96 KB | lisarex |
Comments
Comment #1
yoroy CreditAttribution: yoroy commented- The help text along the top does not make clear how this is related to the exposed functionality (I'd call this a bug)
- The description for the 'put in maintance mode' checkbox describes the exception first, default behavior second (not a bug, also not very elegant)
- The description below the text field for the message is redundant, doesn't add anything that's not contained in the label.
Comment #2
yoroy CreditAttribution: yoroy commentedProposed in this patch:
Comment #3
Dries CreditAttribution: Dries commented- I'd have to double-check but I believe we committed a patch that automatically set Drupal in maintenance mode when running updates? Either way, we can ignore that for now.
- I don't think "Maintenance mode message" is self-explanatory. Maybe we can tweak the label a bit. Maybe we should make the title: "Message to show visitors when in maintenance mode". It is a bit long but it might work.
Comment #4
yoroy CreditAttribution: yoroy commented- Well, I navigated to maintanance mode directly and the 'If you are upgrading…" line just didn't make sense. It happening automatically whille updating doesn't mean we can leave this disconnect imo. I can see how we would have to rewrite that line though.
- Hmmm, true, could be more explicit. It is explained in the description for the checkbox but we shouldn't rely on that. I'll revisit it.
Comment #5
jhodgdonI think the checkbox message should say "only", as in "Visitors will only see the maintenace mode message". Or something to that effect, to indicate they won't see the rest of the site.
I think if there is help text at the top of the screen, it should explain why you would want to use maint mode. Otherwise, just remove the text entirely. I don't think having it start with something about update.php is useful in the least, though. Very confusing.
Comment #6
yoroy CreditAttribution: yoroy commented- Agreed on adding 'only", makes it clearer.
- Running update.php is the main reason for using this page, no? I still have to check what the flow is for updating though.
Comment #7
jhodgdonWell, someone could conceivably decide to put their site in maint mode while they are copying in new versions of modules, uploading some stuff, updating some content types or views, modifying their theme, importing something big, running Services, etc. Or for making database backups.
I.e. not just to run update.php but more generally while they are updating their site. Let's not mention update.php, let's just say something like "to protect your site from being viewed and used by non-administrative users while you are making updates or backups"?
Comment #8
jhodgdonHere's a new patch. Screen shot coming shortly (I'm having trouble with uploads at the moment).
Comment #9
jhodgdonHere's the screen shot.
Comment #12
aspilicious CreditAttribution: aspilicious commentedI think test bot is sick again...
Comment #13
jhodgdonYeah, I don't think that patch should have caused errors in the dblog module, unless some of those tests were specifically looking for text on the Maint Mode page. Which is possible, but not related to the dblog module, so unlikely.
Comment #14
lisarex CreditAttribution: lisarex commentedOK, much better but I think the initial help text is too long and "normal site operation" sounds a bit scary. And we were eradicating overuse of "your site"...
Propose:
Use maintenance mode when making major updates, particularly if the updates could disrupt visitors or the update process. Examples include upgrading Drupal or modules, importing or exporting content, modifying a theme, modifying content types, and making backups.
Comment #15
jhodgdonlisarex: Your wording is MUCH better. Let's get this one in.
Comment #16
webchickOne quick thing. We shouldn't use the word "Drupal" directly in user-facing text. You should use variable_get('site_name', 'Drupal') instead.
Comment #17
jhodgdonThat place where Drupal is being used is "...updating Drupal or modules"...
Saying site name will not work there.
Comment #18
lisarex CreditAttribution: lisarex commentedOK, changed to just say 'upgrading'.
I just hope people know that means upgrading modules, not just core.
Comment #19
jhodgdonsetting status for test bot
Comment #20
jhodgdonAssuming the test bot is happy, I'm happy too, and that pesky word "drupal" has been excised.
Comment #22
lisarex CreditAttribution: lisarex commentedTrying again... testbot, get with it!!! ;)
Comment #23
lisarex CreditAttribution: lisarex commentedchanging status.
Comment #24
cosmicdreams CreditAttribution: cosmicdreams commented#22: 666170d.patch queued for re-testing.
Comment #25
webchickWe're in string freeze now. Let's look at this again in Drupal 8.
Comment #26
yoroy CreditAttribution: yoroy commentedbye CVS, hello Git
Comment #27
drupal_was_my_past CreditAttribution: drupal_was_my_past commentedRecreating patch from #22 as a git patch.
Comment #28
drupal_was_my_past CreditAttribution: drupal_was_my_past commentedOops. Setting status to needs review.
Comment #29
jhodgdonThanks for the re-roll! This text was reviewed, revised, and accepted by at least three people previously, so I'm going to go ahead and mark it RTBC for Drupal 8 only (string change).
Comment #30
Dries CreditAttribution: Dries commentedCommitted to 8.x. Thanks.
Comment #31
drupal_was_my_past CreditAttribution: drupal_was_my_past commentedAwesome.
Also, as a string change, should I generate a patch for 7.x or should it not go into 7.x for localization reasons?
Comment #32
jhodgdonNo, we can't put this into Drupal 7 at this point. It's not a big enough problem to incur the translation issues.
Comment #33
drupal_was_my_past CreditAttribution: drupal_was_my_past commentedGot it. Thanks jhodgdon.