Style cleanup #1 [#666024]

Comment	File	Size	Author
#13	cleanup.patch	14.5 KB	mcrittenden

#3	666024-style-cleanup-1.patch	14.5 KB	boombatower

#1	666024-style-cleanup-1.patch	14.78 KB	boombatower

Comment #1

boombatower CreditAttribution: boombatower commented 22 December 2009 at 20:48

Assigned:	Unassigned	» boombatower
Status:	Active	» Needs review

File	Size
666024-style-cleanup-1.patch	14.78 KB

Log in or register to post comments

Comment #2

22 December 2009 at 21:01

Status:

Needs review

» Needs work

The last submitted patch failed testing.

Log in or register to post comments

Comment #3

boombatower CreditAttribution: boombatower commented 23 December 2009 at 00:25

Status:

Needs work

» Needs review

File	Size
666024-style-cleanup-1.patch	14.5 KB

Log in or register to post comments

Comment #4

24 December 2009 at 00:21

Status:

Needs review

» Needs work

The last submitted patch, , failed testing.

Log in or register to post comments

Comment #5

24 December 2009 at 01:19

Status:

Needs work

» Needs review

Re-test of from comment #2400918 was requested by @user.

Log in or register to post comments

Comment #6

24 December 2009 at 07:01

Status:

Needs review

» Needs work

The last submitted patch, , failed testing.

Log in or register to post comments

Comment #7

27 December 2009 at 02:34

Status:

Needs work

» Needs review

Re-test of from comment #2400918 was requested by @user.

Log in or register to post comments

Comment #9

mcrittenden CreditAttribution: mcrittenden commented 29 December 2009 at 20:19

Looks good on my end. Anybody care to RTBC? Would be good to get this in quickly since re-rolling will be a pain as it touches so many files.

Log in or register to post comments

Comment #10

int CreditAttribution: int commented 29 December 2009 at 20:23

looks good

Log in or register to post comments

Comment #11

Dave Reid

he/him

English

Nebraska USA

CreditAttribution: Dave Reid commented 29 December 2009 at 20:27

+++ includes/bootstrap.inc	23 Dec 2009 00:24:54 -0000
@@ -37,8 +37,9 @@
+ * The item may be remove using cache_clear_all() with a cache ID.

item may be removed

This review is powered by Dreditor.

Log in or register to post comments

Comment #12

Dave Reid

he/him

English

Nebraska USA

CreditAttribution: Dave Reid commented 29 December 2009 at 20:27

Status:

Needs review

» Needs work

Log in or register to post comments

Comment #13

mcrittenden CreditAttribution: mcrittenden commented 29 December 2009 at 20:29

Status:

Needs work

» Needs review

File	Size
cleanup.patch	14.5 KB

#11 fixed here.

Log in or register to post comments

Comment #14

dawehner

German

CreditAttribution: dawehner commented 29 December 2009 at 20:31

Status:

Needs review

» Needs work

+++ includes/cache-install.inc	23 Dec 2009 00:24:54 -0000
@@ -2,13 +2,18 @@
- * need for any persistent storage. Obviously, using this cache
- * implementation during normal operations would have a negative impact
- * on performance.
+ * @file
+ * Provides a stub cache implementation to be used during installation.

indentation

I'm on crack. Are you, too?