Seven theme uses the following font preferences:

font-family: Lucida Grande, Lucida Sans Unicode, sans-serif;

On my system Lucida Sans Unicode selects Lucida Bright which is serif font and looks ugly due to lack of hinting. The only Lucida fonts on my system (Debian 5.0 Lenny) are those installed by sun java: Lucida Bright and Lucida Sans.

When I replace Lucida Sans Unicode with Lucida Sans (or Lucida), Lucida Sans is selected and it looks as expected, that is, great.

Please change font-family in such a way so that Lucida Bright is not selected by fontconfig. Seven is default admin theme and install theme, so I think it's important this to be fixed.

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

ogi’s picture

Title: Lucida can match bad font on some installations » "Lucida Sans Unicode" may match ugly "Lucida Bright" instead of "Lucida Sans"
Status: Active » Needs review
FileSize
621 bytes

It turns out that just adding Lucida Sans explicitly solves the issue.

Dries’s picture

Curious to see a screenshot (but not required).

ogi’s picture

FileSize
166.6 KB
175.76 KB

Screenshots are attached for before and after applying the patch. The combination of low dpi, small size, serif font and no hinting is what makes this professional font look ugly. I took the opportunity to demonstrate (in after patch screenshoot d7-lucida-sans.png) that Java's Lucida Sans doesn't have italics, so system default sans-serif is used for italics (DejaVu Sans) - it looks like bold italics compared to Lucida Sans but it's regular italics.

As I see it, Lucida Grande is Mac font, Lucida Sans Unicode is Windows font, so the natural choice for Linux would be DejaVu Sans because it's installed by default practically on all Linux distributions.

Status: Needs review » Needs work

The last submitted patch failed testing.

Jeff Burnz’s picture

Issue tags: +Quick fix, +Novice

Like to hear some more feedback on this, seems like a very easy fix. We have a lot of linux users and no real complaints from them over the past year, although offline I have heard gripes regarding Sevens font stack.

tim.plunkett’s picture

Status: Needs work » Needs review
FileSize
912 bytes

Basically just a re-roll.

stephthegeek’s picture

Status: Needs review » Needs work

I've got Lucida Sans installed, which is pretty common on a Linux system as part of the Java package. But DejaVu Sans is default and even more common, according to http://www.codestyle.org/css/font-family/sampler-UnixResults.shtml

But Lucida Sans is also fairly common on Windows/Mac, so to target Linux specifically and provide additional fallback for other systems, I would vote to add DejaVu Sans to the stack just ahead of Lucida Sans.

tim.plunkett’s picture

Status: Needs work » Needs review

Cross-post. Adding a completely new font is up to Jeff.

Jeff Burnz’s picture

Well I think stephthegeek knows a lot more about fonts that I ever will :)

I take it the proposal is to do this:

"Lucida Grande", "Lucida Sans Unicode", "DejaVu Sans", "Lucida Sans", sans-serif;

I've added some screen shots to show each font and the subtle differences. Obviously on my system Lucida Grande gets selected although even then in IE9 with the full stack the kerning gets ever so slightly adjusted, which is kind of weird.

Frankly I'm a big fan of Bitstream fonts and would not be opposed to adding DejaVu Sans to the stack.

FWIW I am just one lone voice in the cacophony - my job is more about managing this queue, reviewing patches etc, the real decisions are made by everyone.

Jeff Burnz’s picture

Bah, ignore those screens, try these ones, those grabbed my other screen as well and are huge, sorry.

tim.plunkett’s picture

FileSize
942 bytes

Read that as a feature request, I'm in that sort of mode.

I agree with this, it looks good.

ogi’s picture

Still ugly in Linux.

tim.plunkett’s picture

Version: 7.x-dev » 8.x-dev
Niklas Fiekas’s picture

Status: Needs review » Needs work
emclaughlin’s picture

The problem that I'm seeing is that, because Lucida Sans Unicode is before Lucida Sans, Linux is still matching it to Lucida Bright for whatever reason. Is there a particular reason why Lucida Sans Unicode is preferred over Lucida Sans, or could Lucida Sans go in front of it?

emclaughlin’s picture

Assigned: Unassigned » emclaughlin
Status: Needs work » Needs review
FileSize
795 bytes
795 bytes

The first patch is just the latest patch rerolled for the new directory structure. The second patch reorders the list of fonts to be "Lucida Grande", "Lucida Sans", "Lucida Sans Unicode" since ogi said the problem still existed with them ordered with Lucida Sans at the end.

I'm not sure which one would be more appropriate, but they were both easy enough to do that I figured it wouldn't hurt to leave them here for someone else to make the decision on.

lucascaro’s picture

Issue tags: -Quick fix, -Novice

#16: drupal-seven-662940-16.patch queued for re-testing.

lucascaro’s picture

Status: Needs review » Needs work
Issue tags: +Quick fix, +Novice

The last submitted patch, drupal-seven-reordered-662940-16.patch, failed testing.

rootwork’s picture

Assigned: emclaughlin » rootwork
Status: Needs work » Needs review
Issue tags: +SprintWeekend2013
FileSize
795 bytes
795 bytes

Rerolled both patches from #16 against HEAD. As emclaughlin did, I'll leave it to Jeff or Tim to decide which is the better approach.

socketwench’s picture

Issue summary: View changes
Issue tags: -Novice

Novice issue cleanup.

rootwork’s picture

Assigned: rootwork » Unassigned

Realized I should unassign myself from this since it needs review -- though I'm guessing these patches no longer apply.

Bojhan’s picture

Assigned: Unassigned » LewisNyman

This needs Lewis to look at it.

LewisNyman’s picture

20: drupal-seven-662940-20.patch queued for re-testing.

Status: Needs review » Needs work

The last submitted patch, 20: drupal-seven-662940-20.patch, failed testing.

LewisNyman’s picture

Assigned: LewisNyman » Unassigned
Issue tags: -Quick fix, -SprintWeekend2013 +CSS, +frontend

I'm happy with the idea of adding the new font to the stack (second patch in #20).

This needs a reroll to account for the change in file structure but after that we are ready to go.

rootwork’s picture

Status: Needs work » Needs review
FileSize
973 bytes

Rerolled.

LewisNyman’s picture

Status: Needs review » Reviewed & tested by the community

I quickly checked to make sure the patch applies correctly. This stack has already been manually tested on a variety of machines so I think we're ready to go. Thanks.

Status: Reviewed & tested by the community » Needs work

The last submitted patch, 27: drupal-seven-662940-27.patch, failed testing.

Jeff Burnz’s picture

Status: Needs work » Needs review

27: drupal-seven-662940-27.patch queued for re-testing.

rootwork’s picture

Status: Needs review » Reviewed & tested by the community

Looks like it's good again.

chx’s picture

While a little bit sad over the time this took, the attention to detail of the Drupal community humbles me.

Status: Reviewed & tested by the community » Needs work

The last submitted patch, 27: drupal-seven-662940-27.patch, failed testing.

sqndr’s picture

FileSize
973 bytes

Re-rolling the patch.

rootwork’s picture

Status: Needs work » Needs review

Thanks! Setting to review to trigger the testbot.

sqndr’s picture

Seems like testbot likes the patch? ;-)

LewisNyman’s picture

Status: Needs review » Reviewed & tested by the community

Looks identical to me :)

alexpott’s picture

Status: Reviewed & tested by the community » Fixed

Committed dd24d32 and pushed to 8.x. Thanks!

  • alexpott committed dd24d32 on 8.x
    Issue #662940 by rootwork, tim.plunkett, emclaughlin, sqndr, ogi: Fixed...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

ogi’s picture

Is this going to be commited to 7.x?