Remove the 'relations' column from taxonomy_schema() [#662322]

Comment	File	Size	Author
#8	662322_rm_relations_7.patch	1.1 KB	scor

#7	662322_relations.patch	1.45 KB	andypost

#1	662322_rm_relations.patch	718 bytes	scor

File	Size
662322_rm_relations.patch	718 bytes

Comment #2

scor CreditAttribution: scor commented 17 December 2009 at 16:19

seems forum.install is also using 'relations':

    $edit = array(
      'name' => t('Forums'),
      'machine_name' => 'forums',
      'description' => t('Forum navigation vocabulary'),
      'hierarchy' => 1,
      'relations' => 0,
      'module' => 'forum',
      'weight' => -10,
    );
    $vocabulary = (object) $edit;
    taxonomy_vocabulary_save($vocabulary);

Am I missing something or was taxonomy 'relations' removed from D7? I can't find any other reference to it in D7.

Log in or register to post comments

Comment #3

Dries CreditAttribution: Dries commented 18 December 2009 at 07:31

Status:

Needs review

» Needs work

Log in or register to post comments

Comment #4

8 January 2010 at 07:53

Status:

Needs work

» Needs review

Re-test of 662322_rm_relations.patch from comment #1 was requested by andypost.

Log in or register to post comments

Comment #5

andypost

he/him

Russian

CreditAttribution: andypost commented 8 January 2010 at 09:07

Priority:	Normal	» Critical
Status:	Needs review	» Reviewed & tested by the community

Should be fixed, because admin/structure/taxonomy is not working

Log in or register to post comments

Comment #6

Dries CreditAttribution: Dries commented 8 January 2010 at 10:59

Status:

Reviewed & tested by the community

» Needs work

It seems forum module is still using relations in forum.install. Plus, I don't understand your comment in #5 -- care to elaborate?

Log in or register to post comments

Comment #7

andypost

he/him

Russian

CreditAttribution: andypost commented 8 January 2010 at 11:49

Status:

Needs work

» Needs review

File	Size
662322_relations.patch	1.45 KB

Searching through whole core I found no more usage of 'relations'.
It seems like it was forgotten.

@Dries comment #5 caused by working on #563106: Cannot upgrade from Drupal 6 to Drupal 7 - meta issue - if "relations" field left in schema then after update.php visiting admin/structure/taxonomy brings mysql error: "field base.relations is not found"

This all because taxonomy_get_vocabularies() uses entity_load() which use schema to query DB, but this field is dropped in taxonomy_update_7003()

Log in or register to post comments

Comment #8

scor CreditAttribution: scor commented 8 January 2010 at 11:51

File	Size
662322_rm_relations_7.patch	1.1 KB

removes 'relations' from forum.install (#2).

Log in or register to post comments

Comment #9

andypost

he/him

Russian

CreditAttribution: andypost commented 8 January 2010 at 12:01

Waiting for a bot... very strange that there's no error after normal install only after update or clearing cache[schema]

Notice: Undefined index: severity_level in _drupal_log_error() (line 1195 of /var/www/d7/includes/common.inc).
PDOException: SQLSTATE[42S22]: Column not found: 1054 Unknown column 'base.relations' in 'field list': SELECT base.vid AS vid, base.name AS name, base.machine_name AS machine_name, base.description AS description, base.relations AS relations, base.hierarchy AS hierarchy, base.module AS module, base.weight AS weight FROM {taxonomy_vocabulary} base ORDER BY base.weight ASC, base.name ASC; Array ( ) in DrupalDefaultEntityController->load() (line 126 of /var/www/d7/includes/entity.inc).