Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.With the current API, once a worker has claimed an item, all it can do is:
- either process and delete it when it's done
- or die if it cannot process it
But in the latter case the job won't be available for another worker until the item timeout expires.
The attached patch includes a releaseItem() method for this.
| Comment | File | Size | Author |
|---|---|---|---|
| #3 | queueRelease1.patch | 1.18 KB | fgm |
| queueRelease.patch | 721 bytes | fgm | |
Comments
Comment #1
chx CreditAttribution: chx commentedPlease roll a patch with the -up parameters. (There is a handbook page) For reviewers: we discussed this in IRC and fgm claimed SQS can do a ChangeMessageVisibility(0) for release and beanstalkd has a release op. I am not so sure, the SQS docs say You could call ChangeMessageVisiblity with a value of two hours and the effective timeout would be two hours and 30 minutes. -- so calling it with 0 is a no-op?
Comment #2
Damien Tournoud CreditAttribution: Damien Tournoud commentedFor what I understand, ChangeMessageVisiblity actually works like set_time_limit(): it simply sets the running timeout counter to the new value. In that sense, if your item is about to timeout, calling
ChangeMessageVisiblity(300)actually "extends" its visibility timeout.The example paragraph in
ChangeMessageVisiblityis actually misleading.Comment #3
fgmPatch rerolled. For reference for reviewers:
Comment #4
fgmForgot to set status.
Comment #5
chx CreditAttribution: chx commentedI am fine with this after all. Given that there is no ordering guarantee if a queue implementation cant do this, there is no harm, after all and it can be useful.
Comment #6
Dries CreditAttribution: Dries commentedWhat about DamZ's comment in #2? Is there a documentation improvement required?
Comment #7
fgmI think that the documentation DamZ is referring to is the one provided by Amazon on their site.
In our case, releasing would be performed by a SQS implementation of DrupalQueue by setting visibility to 0, anyway.
Comment #8
Dries CreditAttribution: Dries commentedThanks for clarifying. Committed to CVS HEAD. Thanks.
Comment #9
yched CreditAttribution: yched commentedJust a note that this broke #629794: Scaling issues with batch API, which lies in the RTBC queue for a month.
No harsh feelings, but before updating the patch for the 6th time :-p, I'd like a word of confirmation from drieschick that it has a chance to get in.