Unused case in forum_update()

trying to make the title more accurate: in fact the author does get changed, but other things break as described above.

Also, this database error may be the casue (or one of the causes) of the PHP error described here: http://drupal.org/node/63392

Since changing the author on two forum posts, I'm getting much more frequent errors in the log during cron runs:

Invalid argument supplied for foreach() in /home/prince/public_html/modules/taxonomy.module on line 1199.

Ok, I think this may be a problem with the structure of the forum table. In the forum table 'nid' is set as the PRIMARY. In contrast, in the book table, 'vid' is set as PRIMARY, and I think this should be true for the forum table as well. OR, altrernatively, forum_update() and forum_load() need to be changed.

With the current version of it doesn't look as though revisions are properly handled either in this sense: In the book table, the information about nid, vid, and parent is stored. So if I reverted to a certain vid, I'd also recover the parent that was set at that revision. With forum module, if you changed the forum assignment of a post that would not be recovered currently. However, I'm guessing this is a broader problem/feature with taxonomy.

After looking at the code some more, I'm at a loss to see why there needs to be a forum table at all? All the information is already present in the term_node table. Did there used to be more in the forum table? Are there other modules that add to this table?

Ok, will test and try to make my own patch, but I think this needs a schema change, since I'm seeing the errros on updates, not new nodes.

The patch seems to work fine (obviously, since this hook is never called on insertion of a new node). I tested it with mySQl 4.025, PHP Version 4.4.2.

However, in comparing the book and forum module code to the API example code:

http://api.drupal.org/api/4.7/function/node_example_update

I'm wondering why they don't just call hook_insert() from hook_update() if $node->revision is true?

Also, sorry about posting the rest as an issue. Not solving the SQL error part of this sooner is just a mark of my own ignorance. We started building our site using 4.7beta1, and at some point we must have missed an update and our forum table had the wrong structure.

The dump of the structure of the forum table we were using is:

--
-- Table structure for table `forum`
--

DROP TABLE IF EXISTS forum;
CREATE TABLE forum (
  nid int(10) unsigned NOT NULL default '0',
  vid int(10) unsigned NOT NULL default '0',
  tid int(10) unsigned NOT NULL default '0',
  PRIMARY KEY  (nid),
  KEY vid (vid),
  KEY tid (tid)
) TYPE=MyISAM;

However, the correct schema (from 4.7.0 or 4.7.1) is:

--
-- Table structure for table 'forum'
--

CREATE TABLE forum (
  nid int(10) unsigned NOT NULL default '0',
  vid int(10) unsigned NOT NULL default '0',
  tid int(10) unsigned NOT NULL default '0',
  PRIMARY KEY (vid),
  KEY nid (nid),
  KEY tid (tid)
);

@drumm- See the patch above http://drupal.org/node/65024#comment-102588

Maybe I should have posted a new issue. The instructions at the top should be ignored- my database schema missed a step somewhere between 4.7beta and 4.7.0, but there is still an issue with some stray code in forum.module.