fix to deter from registration SPAM [#64893]

Comment	File	Size	Author
#6	spam.diff_0.txt	633 bytes	beginner
#2	spam.diff.txt	645 bytes	beginner
	registration-spam.diff.txt	634 bytes	beginner

Comment #1

killes@www.drop.org CreditAttribution: killes@www.drop.org commented 22 May 2006 at 17:07

Status:

Needs review

» Needs work

The patch does not comply with coding standards: We use || not OR.

Log in or register to post comments

Comment #2

beginner CreditAttribution: beginner commented 23 May 2006 at 02:22

Status:

Needs work

» Needs review

File	Size
spam.diff.txt	645 bytes

new patch.

I see the different precedence between &&, || and AND, OR.
http://www.php.net/manual/en/language.operators.logical.php

Is there any particular (historical) reason why Drupal must use && and || instead of AND and OR?

Log in or register to post comments

Comment #3

drumm

he/him

NY, US

CreditAttribution: drumm commented 23 May 2006 at 03:12

This doesn't seem to have much to do with "meta roles"; what does this patch do, concisely?

Log in or register to post comments

Comment #4

beginner CreditAttribution: beginner commented 23 May 2006 at 03:17

the patch is relevant to the discussion about spam registration that I addressed on the 'meta-roles' page:

Any person who has administered a vanilla phpBB2 forum knows that spammers like to register phony accounts, just so that there is a link to their web site in the member list. Drupal has exactly the same flaw as phpBB in that it gives an incentive to spammers to register phony accounts with fake email addresses.

This page removes that incentive, because an account that is never activated (because created by a spammer with a fake email or an email they don't own) is not accessible by anonymous or normal users, and most importantly from the spammers' point of view, the page is not accessible by search engines...