Tracker module uses comment.timestamp rather than comment.changed [#642178]

Comment	File	Size	Author
#3	tracker.patch	3 KB	mfb

	tracker.patch	963 bytes	mfb

Comment #1

Dries CreditAttribution: Dries commented 25 November 2009 at 07:02

Issue tags:

+Needs tests

Do we need tests for this?

Log in or register to post comments

Comment #2

mfb

they or he

CreditAttribution: mfb commented 28 November 2009 at 18:48

Issue tags:

-Needs tests

Found another bug in tracker.module and added a test that fails without the patch.

Log in or register to post comments

File	Size
tracker.patch	3 KB

Comment #4

Dries CreditAttribution: Dries commented 29 November 2009 at 10:35

Status:

Needs review

» Fixed

Thanks for the extra tests, and the extra bugfix. I committed the patch to CVS HEAD.

When reviewing the surrounding code, I was puzzled by the various hooks from the comment module. Specifically, the difference between hook_comment_update(), hook_comment_publish() and hook_comment_unpublish() is not at all clear -- and might have causes this bug to begin with.