Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
As part of the profile.module enhancement, a couple typos/grammatical errors were introduced. Below is a list of the ones I noticed, and suggested corrections.
- profile.module
- "Because the form name's usage, spaces or any other special characters except dash (-) and underscore (_) are not allowed. An example for, name is 'profile_favorite_color' or just 'profile_color'." => "Spaces or any other special characters except dash (-) and underscore (_) are not allowed. An example name is 'profile_favorite_color' or perhaps just 'profile_color'."
- "Display this field on member listsings" => "Display this field in member lists"
- "A list op all options." => "A list of all options."
- user.module:
- "Upload picture or picture" => "Upload picture"
- In general, I think I liked the term "avatar" better than "picture." "Picture" seems exceptionally general and doesn't really suggest to users that the image will appear next to their posts. Additionally, in my interpretation of English, "picture" and "image" are synonymous, so phrases like "Failed to upload the picture image" (from user.module) make little or no sense. That's just my opinion, though; I can always use translation to change this on my sites.
I can provide a patch upon request if you feel my changes are reasonable.
Comment | File | Size | Author |
---|---|---|---|
#3 | profile-fix-typos.patch | 3.93 KB | TDobes |
Comments
Comment #1
Dries CreditAttribution: Dries commentedPlease provide patches for the typos. Thanks in advance.
Comment #2
Dries CreditAttribution: Dries commentedPlease provide patches for the typos. Thanks in advance.
Comment #3
TDobes CreditAttribution: TDobes commentedThe attached patch fixes all above-mentioned issues, but does not touch the term "pictures." See my forum response for further discussion about "avatars" vs. "pictures."
Comment #4
Dries CreditAttribution: Dries commentedCommitted to HEAD. Feel free to rename 'picture' to something more meaningful/common but keep in mind not all Drupal users are familiar with forums. Thanks, Tom.
Comment #5
(not verified) CreditAttribution: commented