The field_test helper module implements
a) an entity type
b) a field type + widgets and formatters
c) a field storage backend.

Too much for a single file, it's becoming an unreadable mess. This patch splits those 3 parts in separate include files.

Additionally:
- removes a couple unneeded constants
- moves the module from modules/simpletest/tests (which is supposed to contain helper test modules for /includes files) into /modules/fields/tests where it belongs.
So much for switching between the two directories when writing field patches.

Big patch, 95% is code moving around.
Will probably break one or two pending patches, but less than yesterday and less than tomorrow ;-)
Other than that, should be pretty harmless, but I'll let the bot check.

CommentFileSizeAuthor
#9 field_test_reorg.patch349.27 KByched
#3 field_test_reorg.patch349.27 KByched
field_test_reorg.patch347.72 KByched
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

yched’s picture

yched CreditAttribution: yched commented
Status: Active » Needs review

Status: Needs review » Needs work

The last submitted patch failed testing.

yched’s picture

yched CreditAttribution: yched commented
Status: Needs work » Needs review
FileSize
field_test_reorg.patch349.27 KB

Forgot to update field.info with the new location of the field.test file.

+ Additional reorg: too many test cases under the 'Field' group. Patch splits that into 'Field API' tests and 'Field Types' tests.

yched’s picture

yched CreditAttribution: yched commented

Erm. There is no syntax error in list.test. And the List tests pass fine locally.
I want a re-test with another slave than #33.

Status: Needs review » Needs work

The last submitted patch failed testing.

Status: Needs work » Needs review

yched requested that failed test be re-tested.

Status: Needs review » Needs work

The last submitted patch failed testing.

yched’s picture

yched CreditAttribution: yched commented
Status: Needs work » Reviewed & tested by the community

Sigh, test bot is against me today.
Those 3 failures in DBLogTestCase() are not in this patch. I've seen them reported on another patch and disappeared after a retest. I cannot reproduce them locally.
I opened #638496: Random failures in dblog tests ? about this.

This patch is RTBC.
I could ask for a re-test, but slave #33 reports inexistent PHP syntax errors, and slave #34 reports unrelated test failures. Those are the only two slaves available right now :-(.

yched’s picture

yched CreditAttribution: yched commented
Status: Reviewed & tested by the community » Needs review
FileSize
field_test_reorg.patch349.27 KB

Hm, it's not too clear what happens with those dblog failures.
Let's try to get a green report once again (same patch)

yched’s picture

yched CreditAttribution: yched commented
Status: Needs review » Reviewed & tested by the community

Yay ! Green ! Pushing to RTBC, then.

webchick’s picture

webchick
she/they
Primary language English
Location Vancouver 🇨🇦
CreditAttribution: webchick commented
Status: Reviewed & tested by the community » Fixed

yched asked me to fast-track this. Since it's just moving code around and doesn't actually change much, I committed to HEAD. Hopefully I didn't miss any cvs rm or add commands. :P~

yched’s picture

yched CreditAttribution: yched commented

Gosh, my IDE looks so much better that way :-). Thks !

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.