can't get to unpublished comments? [#6375]

If I go to administer > comments > overview and click on "comment approval queue", I don't see the comment approval queue -- I see already approved comments.

I think this needs to happen:

--- comment.module 2004/03/11 06:15:01 1.4
+++ comment.module 2004/03/11 07:20:26
@@ -1245,7 +1255,7 @@
$output .= comment_admin_overview(0);
break;
default:
- if (arg(3) == 1) {
+ if ($op == 1) {
$output = comment_admin_overview(1);
}
else {

Comment	File	Size	Author
#3	diff2	4.84 KB	jik

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Comment #1

jik CreditAttribution: jik commented 11 March 2004 at 07:33

Comment #2

Dries CreditAttribution: Dries commented 12 March 2004 at 18:55

I can't reproduce this problem with either Drupal 4.3.2, Drupal 4.4.0-RC or Drupal HEAD: using arg(3) looks valid to me.

Comment #3

jik CreditAttribution: jik commented 15 March 2004 at 02:30

File	Size
diff2	4.84 KB

You're right, the arg(3) is working in 4.4.0-rc, but only because the layout of the URLs changed. However, in investigating this I found three other related problems in 4.4.0-rc, for which a patch is attached (I don't think this patch is dependent on the others I'm submitting tonight, but I suppose it may be):

The link for the comment approval queue should be
admin/comment/comments/1, not admin/comment/moderation. Making it
admin/comment/moderation is confusing community-based moderation with
the original intent of this link, which was to allow administrators to
approve unpublished comments.

Fix a typo ("it's" should be "its").

After editing a comment, return to the comments list we were on
before. That is, if we were viewing the list of unpublished comments,
return to that list. This makes it easier to approve unpublished
comments one by one from the list of unpublished comments.
Previously, the code would always display a list of already published
comments after editing a comment.