One element in array is missing.

line 1594

  $access_types = array('user' => t('username'), 'mail' => t('e-mail'));

i think...

  $access_types = array('user' => t('username'), 'mail' => t('e-mail'), 'host' => t('host'));
CommentFileSizeAuthor
#6 access_types_host.patch793 bytesasimmonds
#5 user.module.patch_8.txt772 bytesTakafumi
#3 user.module.patch_7.txt511 bytesTakafumi
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

magico’s picture

magico CreditAttribution: magico commented
Version: 4.7.0 » x.y.z
Status: Active » Closed (fixed)

Where? In what function?

Takafumi’s picture

Takafumi CreditAttribution: Takafumi commented
Status: Closed (fixed) » Active

It's minor bug, but the type of the rule will not be shown in the confirmation message when the access rule is deleted.

Takafumi’s picture

Takafumi CreditAttribution: Takafumi commented
Status: Active » Needs review
FileSize
user.module.patch_7.txt511 bytes

This patch to fix it.

edmund.kwok’s picture

edmund.kwok CreditAttribution: edmund.kwok commented

Patch works but please rerolls from drupal root :-)

Takafumi’s picture

Takafumi CreditAttribution: Takafumi commented
FileSize
user.module.patch_8.txt772 bytes

ok, I reworked it.

asimmonds’s picture

asimmonds CreditAttribution: asimmonds commented
FileSize
access_types_host.patch793 bytes

Patch in #5 doesn't apply properly, re-rolled from Drupal root.

edmund.kwok’s picture

edmund.kwok CreditAttribution: edmund.kwok commented
Status: Needs review » Reviewed & tested by the community

Patch applies cleanly to HEAD. Minor bug, minor fix, RTBC.

Dries’s picture

Dries CreditAttribution: Dries commented
Status: Reviewed & tested by the community » Fixed

Committed to CVS HEAD. Thanks.

Dries’s picture

Dries CreditAttribution: Dries commented

Committed to CVS HEAD. Thanks.

Anonymous’s picture

(not verified) CreditAttribution: commented
Status: Fixed » Closed (fixed)