Duplicate modules cause epic fail

Right, but they don't.

Working on this.

So far, drupal_get_install_files() returns the proper .install file locations, and only one of them for simpletest.

system_rebuild_module_data() seems to exhibit the behavior I noticed.

It says simpletest is in modules directory, yet picks up the .info file information from the one in sites (double whammy).

Would seem it has to do with:

  system_get_files_database($modules, 'module');
  system_update_files_database($modules, 'module');

Not updating to the proper file since the database has the wrong file, but:

$modules = drupal_system_listing('/\.module$/', 'modules', 'name', 0);

returns the right one (which is used for .info file parsing).

Not sure why this code is so extremely convoluted.

It would seem that one function (for scanning file system) would be enough then...you update file listing ..and read .info files.

Secondly, I have no idea what the purpose of the get and then update the files database...as from scanning it would appear no change is made...the files table is simply re-written.

The names are not clear, but either way since both modules and themes have info files they still share everything in common and should be able to use the same function, I am not seeing why the info file parsing is completely separate or if anything why they do not use the same method to seek the actual files.

Either way, the functions that seek the files do not function properly, when I get time I'll try and figure it out, otherwise it would be great if someone else had time to fix them.

Win on the "key" instead of "$key".

That doesn't really work since it should always override. We only care about levels when modules/ vs sites/all vs sites/xyz.

And we dont' have write access to sites/[non-files] or modules/ so unless we do somethign interesting it isn't really possible since we need to gen module on the fly. (or break rules)

Double wammy, bad test as well, since $array1 == $array2 or $array1 === $array2 will only be equal if they are in the same order, which sadly the test it trying to check once in order and once not, but uses same assertion.

For example:

$array1 = array(
  'foo',
  'bar',
);

$array2 = array(
  'bar',
  'foo',
);

var_dump(array_diff($array1, $array2));
var_dump($array1 == $array2);

Results in:

array(0) {
}
bool(false)

Which is what we want.

Here are the arrays the test has when it runs.

$a1 = array ( 'block' => 'block', 'color' => 'color', 'comment' => 'comment', 'dashboard' => 'dashboard', 'dblog' => 'dblog', 'default' => 'default', 'field' => 'field', 'field_sql_storage' => 'field_sql_storage', 'field_ui' => 'field_ui', 'file' => 'file', 'filter' => 'filter', 'help' => 'help', 'image' => 'image', 'list' => 'list', 'menu' => 'menu', 'node' => 'node', 'number' => 'number', 'options' => 'options', 'path' => 'path', 'rdf' => 'rdf', 'search' => 'search', 'shortcut' => 'shortcut', 'system' => 'system', 'taxonomy' => 'taxonomy', 'text' => 'text', 'toolbar' => 'toolbar', 'user' => 'user', );
$a2 = array ( 'block' => 'block', 'color' => 'color', 'comment' => 'comment', 'dashboard' => 'dashboard', 'dblog' => 'dblog', 'field' => 'field', 'field_sql_storage' => 'field_sql_storage', 'field_ui' => 'field_ui', 'file' => 'file', 'filter' => 'filter', 'help' => 'help', 'image' => 'image', 'list' => 'list', 'menu' => 'menu', 'node' => 'node', 'number' => 'number', 'options' => 'options', 'path' => 'path', 'rdf' => 'rdf', 'search' => 'search', 'shortcut' => 'shortcut', 'system' => 'system', 'taxonomy' => 'taxonomy', 'text' => 'text', 'toolbar' => 'toolbar', 'user' => 'user', 'default' => 'default', );

var_dump($a1 === $a2); // Result: false

var_dump(array_diff($a1, $a2)); // Result: empty array

ksort($a1);
ksort($a2);

var_dump($a1 === $a2); // Result: true

var_dump(array_diff($a1, $a2)); // Result: empty array

Only difference is default is in a new location.

Looking into this.

Ah, yes @Dave Reid: your example uses "==" when assertIdentical() uses "===".

I'll update test to use == and then we don't need array_diff().

chx said it was worthy of a phpwtf: http://www.phpwtf.org/identical-arrays-vs-equal-arrays.

For clarification, #19 works great for me at solving the problem, just need someone to "review" the patch.

Here ya go.

oo...lets get this in.