If you apply the patch at #510094-25: Add description to the link items of the toolbar you'll notice some glaring inconsistencies with how our toolbar menu items are labeled.
For whatever reason, People, Dashboard, Configuration and Modules, and Help don't have descriptions, but Appearance, Structure, Content, and Reports do.
We should either have a description on everything, or on nothing. Confer with the UX team in #drupal-usability on IRC for advice on which way to go.
Comment | File | Size | Author |
---|---|---|---|
#24 | 620616new.patch | 6.7 KB | jhodgdon |
#18 | change.menu_.description.patch | 6.36 KB | Bojhan |
#14 | altnoperiod.patch | 6.29 KB | lisarex |
#12 | alttags.new_.patch | 6.3 KB | reglogge |
#10 | cleanup.alttags.patch | 3.22 KB | Bojhan |
Comments
Comment #1
lisarex CreditAttribution: lisarex commentedComment #2
Bojhan CreditAttribution: Bojhan commentedThese should indeed have alt texts.
Comment #3
lisarex CreditAttribution: lisarex commentedHere's a first pass at adding/improving the text on the description that appear when you hover over the admin menu items. (See attached)... Thoughts?
Dashboard
Current: none
Proposed: View and customize your dashboard
Content
Current: none
Proposed: Administer your site's content and comments
Structure
Current: Control how your site looks and feels.
Proposed: Administer your site's blocks, content types, menus and other components
Appearance
Current: Select and configure your site theme
Proposed: (keep as is)
People
Current: none
Proposed: Manage your site's users
Configuration and modules
Current: none
Proposed: Administer your site settings and modules
Reports
Current: View reports from system logs and other status information.
Proposed: View your site's reports, updates and errors
Help
Current: none
Proposed: Get help with managing and using your site
Comment #4
lisarex CreditAttribution: lisarex commentedComment #5
yoroy CreditAttribution: yoroy commentedGood job. Finding all the 'your site's a bit too much, and not necessarily true, (though it always is for first time. That this is 'your site' is implied imo. Who says it's even a web site? Let's not explicitly label it. 'Your dashboard' is true though and sounds comfy and also fitting for theme. Would like to avoid using 'users' and add the 'account' triggerword for people. Config and modules is hopelessly generic but I see no way to really fix that. Don't like the Help one yet but have no suggestion for now.
Dashboard
View and customize your dashboard
*Content
Administer content and comments
*Structure
Administer blocks, content types, menus and other components
*Appearance
Select and configure your theme
*People
Manage user accounts
Configuration and modules
Administer settings and modules
*Reports
View reports, updates and errors
Help
Get help with managing and using your site
Comment #6
yoroy CreditAttribution: yoroy commented'components' is a new word in the Drupal ui vocabulary. yay/nay?
Comment #7
lisarex CreditAttribution: lisarex commentedComment modified:
Your suggestions are great! For help, how about:
Help
Reference for usage, configuration and modules
(it avoids using 'your site', anyway ;-))
P.S. In IRC we all agreed nay on 'components'
Comment #8
lisarex CreditAttribution: lisarex commentedCool, so #510094: Add description to the link items of the toolbar is RTBC, so would be great to have a dev add these other text appearing on all the toolbar menu items.
Comment #9
webchickI've just committed #510094: Add description to the link items of the toolbar so.. ping. :)
Comment #10
Bojhan CreditAttribution: Bojhan commentedThere we go, can anyone check if this actually worked? It didn't seem to do so for me, perhaps I am adding them at the wrong place?
Comment #11
Bojhan CreditAttribution: Bojhan commentedMr.Bot :)
Comment #12
reglogge CreditAttribution: reglogge commentedPatch worked but "People" still had no description.
- Added "Manage user accounts." to "People"
- Added all text snippets according to #5
I also noticed that "Administer content and comments." for "Content" comes from comment.module as an override to the simpler string "Administer content" from node.module. Is this by design?
Strings are now:
*Dashboard
"View and customize your dashboard."
*Content
"Administer content."
(with comment module disabled)
"Administer content and comments."
(with comment module enabled)
*Structure
"Administer blocks, content types, menus and other parts." ("other parts" still sounds fishy, how about "taxonomy"?)
*Appearance
"Select and configure your theme."
*People
"Manage user accounts."
*Modules
"Enable or disable add-on modules."
*Configuration
"Adminster settings and modules"
*Reports
"View reports, updates and errors."
*Help
"Reference for usage, configuration and modules."
Rolled new patch.
Comment #13
reglogge CreditAttribution: reglogge commented@Bojhan #10:
You have to clear cache after applying the patches. Otherwise the new strings don't show up.
Comment #14
lisarex CreditAttribution: lisarex commentedApplied patch and this is awesome. :)
I'm not sure about all the full stops (periods) though. They look odd because they aren't supposed to be a sentence, just a bit of text. so I've rerolled without them.
Comment #15
jhodgdonI don't like:
"'Administer blocks, content types, menus and other parts"
Other parts of what?
"Enable or disable add-on modules" -- some of the modules are included in Drupal core, so are they really "add-on"?
"Administer settings and modules" -- modules are not part of Configuration any more. Also there is a formatting problem with that line of the patch.
Sigh. We had another issue at #666176: Missing or incorrect title attributes in toolbar top level links that was marked recently as a duplicate of this issue (it is), which has a bunch of my suggestions and a bunch more discussion... Generally I would say that title attributes should only be used if they say something different or clarify the link text.
Comment #16
Bojhan CreditAttribution: Bojhan commented"Administer blocks, content types, menus and taxonomy"
What about that? I know its not totally correct, but finding a diffrent word for parts other then component seems hard.
"Enable or dissable add-on modules"
We can probaly drop the add-on, not sure what it adds.
"Administer settings and modules"
This is actually correct, as you can administer settings (comming from core) and you can administer modules their settings. But more correct would be "Administer settings of modules".
Comment #17
jhodgdon"administer settings of modules" -- what does the "of modules" add to this? How about just "administer settings"?
How about "Administer the foundations of your site: blocks, content types, menus, etc." for structure? No, I probably don't like that either. So how about "Administer blocks, content types, menus, etc." I really don't like having an enumerated list that doesn't make room for more things to be added later.
Anyway, let's get a patch in with something reasonable...
Comment #18
Bojhan CreditAttribution: Bojhan commentedOk
Comment #19
jhodgdonA few minor changes needed:
"Reference for usage, configuration and modules" needs a comma before "and", as per our standard style guidelines.
Same for "View reports, updates and errors".
"etc" needs to be "etc."
"Select and configure your theme" -- should that be themes, since I think sites can have more than one enabled/configured?
Indentation problem:
Comment #20
jhodgdonOne other issue: There is nothing showing up when I hover over the Home icon in the Toolbar.
Comment #21
jhodgdonOr on the "Hello jhodgdon" button over on the right side. This should surely have a tooltip, since "hello jhodgdon" is not necessarily intuitively going to take you to your user account page...
Comment #22
jhodgdonOne other thing (sorry, should have put these together probably): I noticed that all of these start with verbs except Help, which says "Reference for...". Should it maybe say "View reference information for..."? I guess I am in favor of leaving it as a noun, since it's clear. ???
Comment #23
Bojhan CreditAttribution: Bojhan commentedjhodgdon : Could you make a patch? I am not really following, all that you suggest :')
Comment #24
jhodgdonSure. Sorry. :)
Comment #25
Bojhan CreditAttribution: Bojhan commentedOk this is RTBC
Comment #26
webchickThough not reflected above, (Test result: "None"? Huh?) It appears testbot passed this patch with no issues.
Committed to HEAD.