no db_rewrite_sql() in taxonomy/autocomplete

please don't set to rtbc before a review.

We currently don't rewrite anything other than node queries. Adding taxonomy will terms many more changes than one query.

Drumm, that's not correct, we do rewriting for much more than node queries.

Doesn't work.

user warning: Unknown table 't' in field list query: SELECT t.name FROM term_data WHERE t.vid = 2 AND LOWER(t.name) LIKE LOWER('%f%') LIMIT 0, 10 in /home/drumm/drupal/drupal/C-HEAD/includes/database.mysql.inc on line 120.

you submitted an emtpy patch ;)

I am not 100% sure, but wouldn't db_rewrite_sql need t.tid in the select statement in order to work?

db_rewrite_sql("SELECT t.tid, t.name FROM {term_data} t WHERE t.vid = %d AND LOWER(t.name) LIKE LOWER('%%%s%%')", 't', 'tid'), $vid, $last_string, 0, 10)

shouldn't the query look like this?

Committed to HEAD (with the extra column suggested by killes).