Double spaced sentences cleaned up [#61802]

Comment	File	Size	Author
#4	doublespace.patch_0.txt	131.92 KB	Zen
	doublespace.patch.txt	147.01 KB	Zen

Comment #1

drumm

he/him

NY, US

CreditAttribution: drumm commented 4 May 2006 at 09:38

Status:

Needs review

» Closed (won't fix)

While it is good to have single spacing, this would cause the translations of all these strings to be lost. It will be best to remove these as the various strings are changed for other reasons. Slow, but translatable.

Talk to killes about this issue if you want to think of ways to move ahead, he maintains locale.

Log in or register to post comments

Comment #2

Zen CreditAttribution: Zen commented 4 May 2006 at 10:17

This early in the cycle?

Looking at it from another perspective, there are ~140 t()s in this patch. If one assumes that about 50% of these will be modified by the time 4.8 is out, this patch will introduce minor whitespace work on 70 t()s.. And if one takes into account the plans to nix a third of the modules in core, this number becomes lower and lower.

Stats:
Total lines in patch: 1791
Total fixes: ~870
t()s fixed: ~140
Others [comments + text files]: ~730
License.txt lines fixed: ~130
Comments fixed: ~600

IMO, it's best to do this now, rather than progressively or later.

My 10p.

Thanks,
Karthik.

Log in or register to post comments

Comment #3

killes@www.drop.org CreditAttribution: killes@www.drop.org commented 4 May 2006 at 11:02

Status:

Closed (won't fix)

» Needs work

1) double spaces won't be shown in HTML, so it is kind of pointless to fix them. :P
2) Many of the patched places are in documentation strings, which don't get translated.
3) Don't change the license file, we want it to be 1:1 with the official GPL version, I think.
4) breakign translations isn't nice, but will occur anyway and this is a patch for head. Translations won't be completely lost, but probably will only be marked as "fuzzy".