Non-empty Summary and empty Body both become empty when saved.

Bug is confirmed.

When you remove the content from the full text area, the row data is also getting deleted from the database table 'field_data_body'

Update :

./modules/node/node.module:function node_save($node) : If the full text is not present then the $node does not contain any value for $node->body

["body"]=> array(1) { ["zxx"]=> array(0) { } }

The correct values should be :

["body"]=> array(1) { ["zxx"]=> array(1) { [0]=> array(4) { ["summary"]=> string(22) "This is a sample text" ["value"]=> string(0) "" ["format"]=> string(1) "1" ["value_format"]=> string(1) "1" } } }

It considers it as the same situation as both the body summary and full text field being empty.

Confirmed

I think I found where problem is. Function text_field_is_empty (modules/field/modules/text/text.module) return TRUE if body field is empty even if summary is not empty. After that function _field_filter_items (modules/field/field.module) unset body field (and summary field too).
Current code for text_field_is_empty function is:

function text_field_is_empty($item, $field) {
  if (empty($item['value']) && (string) $item['value'] !== '0') {
    return TRUE;
  }
  return FALSE;
}

We should use following code:

function text_field_is_empty($item, $field) {
  if (empty($item['value']) && (string)$item['value'] !== '0') {
    if ($field['type'] == 'text_with_summary') {
      return (empty($item['summary']) && (string)$item['summary'] !== '0');
    }
    else {
      return TRUE;
    }
  }
  return FALSE;
}

Also I found patch for this function - http://drupal.org/files/issues/body-as-field.patch . But this patch failed test (http://qa.drupal.org/pifr/test/5791) so we can't use this patch. Instead of that we can create another patch:

 function text_field_is_empty($item, $field) {
   if (empty($item['value']) && (string)$item['value'] !== '0') {
-    return TRUE;
+    if ($field['type'] == 'text_with_summary') {
+      return (empty($item['summary']) && (string)$item['summary'] !== '0');
+    }
+    else {
+      return TRUE;
+    }
   }
   return FALSE;
 }

Here is patch for #3. But there is another problem that is raised after applying it. When you Edit the node with Summary only, summary field collapsed. Also I believe we need to make test for this case (empty body and not empty summary).

+    if ($field['type'] == 'text_with_summary') {
+       return (empty($item['summary']) && (string)$item['summary'] !== '0');
+    }
+    else {
+      return TRUE;
+    }

There is a slight indenting issue here.

Yes. Identing issue fixed.

[edited out, I was on crack]

Here is patch including fix for javascript. Please review.

Here is patch with test.

+++ modules/field/modules/text/text.test	14 Oct 2010 17:54:04 -0000
@@ -372,6 +377,26 @@ class TextSummaryTestCase extends Drupal
+    // Translate the article in french.

Sorry ?

+++ modules/field/modules/text/text.test	14 Oct 2010 17:54:04 -0000
@@ -372,6 +377,26 @@ class TextSummaryTestCase extends Drupal
+    ¶

white line should have no spaces

Other than that, patch looks good.

Powered by Dreditor.

Thank you for the review. I have cleaned the patch.

fine, thanks !

Committed to HEAD. Thanks!

+++ modules/field/modules/text/text.module	15 Oct 2010 05:27:26 -0000
@@ -171,7 +171,12 @@ function text_field_load($entity_type, $
 function text_field_is_empty($item, $field) {
   if (empty($item['value']) && (string) $item['value'] !== '0') {
-    return TRUE;
+    if ($field['type'] == 'text_with_summary') {
+      return (empty($item['summary']) && (string)$item['summary'] !== '0');
+    }
+    else {
+      return TRUE;
+    }
   }
   return FALSE;

Erm. This entire condition construct looks very odd.

The initial condition likely meant

isset($item['value']) && $item['value'] === ''

Same for the condition that has been introduced.

Powered by Dreditor.

This also catches $item['value'] === NULL, or $item === array()
I'd leave it that way.

Alright, so we actually mean:

!isset($item['value']) || $item['value'] === ''

Sure.

Committed to HEAD. Thanks!