I have not found a suitable category for 'possibly' bugs in the batch system.

Line 450 of the batch.inc file is:

      $function($_batch['source_url'], array('query' => array('op' => 'finish', 'id' => $_batch['id'])));

This is something that should happen when the origin form contains a redirection. The problem is that I have not found the origin of this variable, but I've found "source_page", used in this batch.inc file, and created in form.inc, in the function batch_process().

Is source_url an error and should be source_page? of course I'm getting a nasty red error message.

CommentFileSizeAuthor
#3 617420-batchapi-source_url.patch921 bytesksenzee
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

ksenzee’s picture

Category: support » bug

Looks like a bug to me, introduced in #555762: Changes to batch API:

-    drupal_goto($_batch['source_page']);
+    $function = $_batch['redirect_callback'];
+    if (function_exists($function)) {
+      $function($_batch['source_url'], array('op' => 'finish', 'id' => $_batch['id']));
+    }
yched’s picture

Indeed, source_page / source_url mixup. Let's go with source_url for consistency with other batch properties. Care to roll a patch ?

ksenzee’s picture

Status: Active » Needs review
FileSize
921 bytes

ilo, does this work for you?

ilo’s picture

It does work for me, I've tested also manually and no errors. Thanks!

yched’s picture

Status: Needs review » Reviewed & tested by the community

Thanks for the patch and detective work, ksenzee !

hass’s picture

+

webchick’s picture

Status: Reviewed & tested by the community » Fixed

Committed to HEAD. Thanks!

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.