Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.In 4.7.0, theme.inc/theme_form_element formats titles by appending a semicolon and the $required variable. However, although this may be proper for english, other languages (like french) require a non-breaking space before a semicolon.
The suggested patch to theme.inc corrects this behaviour for theme.inc, but it might exist elsewhere within core and need a more generic solution.
The patch for spplied for the french theme.po includes that change and new strings from the updated .pot for 4.7.
| Comment | File | Size | Author |
|---|---|---|---|
| #6 | theme-inc.po_0.patch | 2.42 KB | fgm |
| #5 | theme.inc_5.patch | 841 bytes | fgm |
| #3 | theme-inc.po.patch | 2.37 KB | fgm |
| #2 | theme.inc_4.patch | 739 bytes | fgm |
| semicolon.tar.gz | 1.18 KB | fgm | |
Comments
Comment #1
fgmSorry, forgot to set status.
Comment #2
fgmKilles told me not to submit tarred patches, so here is the theme.inc patch first.
Comment #3
fgmAnd this is the theme-inc.po patch for the French translation
Comment #4
killes@www.drop.org CreditAttribution: killes@www.drop.org commentedOk, that should be fixed but not in this way:
t('%title: %required', array('%title' => $title, '%required' => $required));
seems to be better.
Comment #5
fgmIndeed: it avoids string collision with other semicolons elswehere. Here is the new version of the theme.inc patch
Comment #6
fgmAnd here is the revised patch for the french translation of theme.inc (theme-inc.po)
Comment #7
drummComitted to HEAD.
Comment #8
(not verified) CreditAttribution: commented