Option to send node content as an attachment to the e-mail

No, the module isn't capable of doing what you're asking at the moment.

It would be a nice addition to have it as well as an option to just send a URL back to the site. Maybe when I have time or someone contributes a patch..

João

Hi,

First, let me say thank you for such a nice patch. It isn't often that I ask for patches and people actually make them.

However, it isn't quite ready to be applied for the following reasons:

1. It tries to do too much. Please split the patch in two and attach the MIME attachment part to this issue. Create a new issue for the unrelated things and attach the other part of the patch there.

2. Wrap the calls to parts that require the Mail_mime PEAR library in conditions that detect for that library. Like this:

if (@include_once('Mail/mime.php')) {
    // Plan A;
}

3. The new token + content-type-specific settings (which BTW is actually not CCK-specific), is just a big mess. The gravest part is that you're re-introducing security vulnerabilities that were fixed in recent issues. Also, the module is able to deal with non-nodes and one of the first lines in the patch makes a node_load() without checking if this is a node. Also, why is the nid being inserted as a form field if it isn't even used at all, etc, etc.

4. The patch isn't even based on the code in Drupal.org, as the whole first block of changes are to delete some lines which aren't there.

In conclusion, I do like the attachment part (even though I would like to have the option to not send the page at all, and send only the pages's URL. That patch I would review, test and commit ASAP. The rest needs a lot of work before I do more than review it in the browser.

João

I'll probably add the library check in the admin form before presenting this option to the user, but other than that (and the URL-only option), I only need this to be reviewed by me and/or others.

As to the URL-only option, it's simply that.. Instead of sending the node contents, force a visit to the site by providing an "a href" link with the original page URL with the anchor text being the page title. The mail itself would still be HTML, or a plain text version.

João

PS: As to the 3rd point in my previous comment, indeed it wasn't very constructive. I will try to finish this patch and some minor ones and then I will take a deeper look at the other issue, where I hope to be more constructive. You can easily identify the security fixes you re-introduced by searching for filter_xss in the patch and looking for the lack of that function in the new lookups of the variables being sanitized in the old code.

I tried the #7 patch. The send link works. Plain text with attachment produces:
Fatal error: Class 'Mail_mime' not found in /sites/all/modules/print/print_mail/print_mail.inc on line 373

That would be because you don't have the Mail_Mime library installed.

Looking at the code of the #7 patch, where it's written:
switch($form['fld_send_option']) {
should be
switch($form_state['values']['fld_send_option']) {

Note that I have just written the above by looking at the code, so it may not even work like that.. You should now be denied the option to set the "* with Attachment" options in the settings page.

The patch now highlights the Send page as field in red and produces the messages:
* warning: include_once(Mail/mime.php) [function.include-once]: failed to open stream: No such file or directory in /home/example/public_html/sites/all/modules/print/print_mail/print_mail.inc on line 243.
* warning: include_once() [function.include]: Failed opening 'Mail/mime.php' for inclusion (include_path='.:/usr/lib/php:/usr/local/lib/php') in /home/example/public_html/sites/all/modules/print/print_mail/print_mail.inc on line 243.
* The PEAR Mail_mime library is required for this send option and was not found.

I installed PEAR Mime mail using Cpanel and the module was installed in path /home/example/php. I then found the WHM PEAR installer which installs the module in the right place and the email worked.

The received email was not in the format I was expecting. I will open a separate issue about the format.

Well, instead of trying to check for the include file, it would be better to check for class_exists() as that won't produce the warnings. I really have to find some time to try this... Unfortunately, I am in the same boat as you are, as that library is not installed in my test system, so I guess I will test that aspect first. :)

João

hey guys, whats the status of this?

yea - this is pretty cool.. what's up? ;)

As someone noted, this isn't compatible with the SMTP module. After a lot of fiddling I found out there's an alternative to SMTP - http://drupal.org/project/phpmailer. Got this set up together with the Mime module and now it's working fine!

Thanks for the patch. I've just committed it to CVS.

Sorry that it took almost a year :)

Would it be possible to change the default? currently it is defaulting to Plain Text with Attachment.

Thanks!

I guess that no default will be OK. So indeed, I've added an option to the email settings form.

In D7, I only have the options 'Link' and 'Inline HTML'. Must this patch still be ported, or do I need to install/activate other parts of the module/library?

It must still be ported. But D7 still needs a lot of work anyway.. When I sync D6 to D7 that will be added.

Is it possible to attach as PDF instead of HTML ?