Add content_attributes variable for tpl files, so RDF can be implemented better. [#608036]

Comment	File	Size	Author
#12	608036_user_profile_attr_12.patch	1.95 KB	scor

#10	608036_user_profile_attr_10.patch	1.94 KB	scor

#9	608036_user_profile_attr_9.patch	1.82 KB	scor

#1	drupal-theme-content_attributes-608036-1.patch	5.96 KB	effulgentsia

Comment #1

effulgentsia CreditAttribution: effulgentsia commented 18 October 2009 at 21:22

Priority:	Critical	» Normal
Status:	Reviewed & tested by the community	» Active
Issue tags:	-RDF

File	Size
drupal-theme-content_attributes-608036-1.patch	5.96 KB

It's really a no-brainer and I don't know how I missed it in the earlier issue. All the tpl file already have a div for the content, and that's the div that should be used for RDF attributes that describe the content of the entity as opposed to the entire entity. The current RDF patch gets around it by putting an extra div around the content where it needs it, but this way, we can remove redundant divs.

Log in or register to post comments

Comment #2

sun

German

Karlsruhe

CreditAttribution: sun commented 18 October 2009 at 21:19

Status:

Active

» Reviewed & tested by the community

Makes perfectly sense.

Log in or register to post comments

Comment #3

sun

German

Karlsruhe

CreditAttribution: sun commented 18 October 2009 at 21:20

Priority:	Normal	» Critical
Issue tags:		+RDF

Log in or register to post comments

Comment #4

moshe weitzman CreditAttribution: moshe weitzman commented 18 October 2009 at 22:22

Priority:	Normal	» Critical
Status:	Active	» Reviewed & tested by the community
Issue tags:		+RDF

+1 from me too

Log in or register to post comments

Comment #5

scor CreditAttribution: scor commented 19 October 2009 at 00:14

Priority:

Critical

» Normal

I confirm this solves the intended issue. already committed as part of #493030: RDF #1: core RDF module

EDIT: I meant included for now in the patch #493030: RDF #1: core RDF module until this is committed.

Log in or register to post comments

Comment #6

sun

German

Karlsruhe

CreditAttribution: sun commented 19 October 2009 at 00:23

Priority:

Normal

» Critical

Slight confusion about the term "committed", I guess.

Log in or register to post comments

Comment #7

Dries CreditAttribution: Dries commented 19 October 2009 at 01:30

Status:

Reviewed & tested by the community

» Fixed

Looks good to me, committed to CVS HEAD. Thanks!

Log in or register to post comments

Comment #8

2 November 2009 at 01:40

Status:

Fixed

» Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

Log in or register to post comments

Comment #9

scor CreditAttribution: scor commented 6 January 2010 at 20:03

Status:

Closed (fixed)

» Needs review

File	Size
608036_user_profile_attr_9.patch	1.82 KB

The patch #1 didn't cover user-profile.tpl.php. Tests included.

Log in or register to post comments

Comment #10

scor CreditAttribution: scor commented 6 January 2010 at 20:04

File	Size
608036_user_profile_attr_10.patch	1.94 KB

fix documentation

Log in or register to post comments

Comment #11

sun

German

Karlsruhe

CreditAttribution: sun commented 6 January 2010 at 22:45

+++ modules/rdf/rdf.test
@@ -187,4 +187,21 @@ class RdfMappingDefinitionTestCase extends DrupalWebTestCase {
+  function testAttributesInMarkup4() {

4?

+++ modules/rdf/rdf.test
@@ -187,4 +187,21 @@ class RdfMappingDefinitionTestCase extends DrupalWebTestCase {
+    $this->assertTrue(!empty($user_profile_about), t('RDFa markup found on user profile page'));
+
+  }

Please remove this blank line.

Powered by Dreditor.