theme('taxonomy_term_select', $element) called, but output is ignored [#60797]

As seen in taxonomy.module, _taxonomy_term_select returns a form element with a #type of 'select' and a #theme value of 'taxonomy_term_select'. However, despite my best efforts, I have found it impossible to theme the taxonomy term selection drop down list without retheming theme_select.

After a bit of debugging, I discovered theme('taxonomy_term_select', $element) is called, but its output is ignored and theme('select') is used instead, even if the default theme_taxonomy_term_select function (which simply calls theme('select', $element)) is overridden.

I have a feeling this may be a bug in the new Form API's form_render function, but I could be wrong. Let me know if more information is needed to resolve this bug, I would love to see it fixed for the 4.7 release.

Comment	File	Size	Author
#15	form_comment.patch	900 bytes	Zen
#15
#9	drat.patch	940 bytes	chx
#9
#6	theme_wo_children_0.patch	1.64 KB	chx
#6
#4	theme_wo_children.patch	671 bytes	chx
#4
#1	drupal-60797.patch	571 bytes	speakout_tom
#1

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Comment #1

speakout_tom CreditAttribution: speakout_tom commented 28 April 2006 at 05:11

Status:

Active

» Needs review

File	Size
drupal-60797.patch	571 bytes

Fixed using 'markup' instead of 'select' for the #type attribute of the element returned by _taxonomy_term_select. Patch attached.

Comment #2

adrian CreditAttribution: adrian commented 28 April 2006 at 11:48

Status:

Needs review

» Needs work

It might look correct with that patch, but there's no way we could validate against it.

How are you trying to theme it ?

Have you tried using form_alter and using the '#theme' property ?

Comment #3

chx CreditAttribution: chx commented 28 April 2006 at 12:04

Adrian, the problem is something like that #theme callbacks render children but the actual element is still rendered by the element renderer. What we need here is that if the children are empty but there is content then we should not call the element renderer.

Comment #4

chx CreditAttribution: chx commented 28 April 2006 at 12:10

File	Size
theme_wo_children.patch	671 bytes

Something like this...

Comment #5

adrian CreditAttribution: adrian commented 28 April 2006 at 12:16

I think chx' solution is correct for this.

Comment #6

chx CreditAttribution: chx commented 28 April 2006 at 12:33

Component:	taxonomy.module	» forms system
Status:	Needs work	» Reviewed & tested by the community

File	Size
theme_wo_children_0.patch	1.64 KB

Comment #7

Gerhard Killesreiter CreditAttribution: Gerhard Killesreiter commented 28 April 2006 at 12:41

Status:

Reviewed & tested by the community

» Fixed

applied

Comment #8

Zen CreditAttribution: Zen commented 28 April 2006 at 17:40

Version:	4.7.0-rc3	» x.y.z
Priority:	Normal	» Critical
Status:	Fixed	» Active

node edit form: Associated terms are no longer being preselected.

-K

Comment #9

chx CreditAttribution: chx commented 29 April 2006 at 00:14

Assigned:	Unassigned	» chx
Status:	Active	» Reviewed & tested by the community

File	Size
drat.patch	940 bytes

Of course not when #value is overwritten! I forgot the last change here.

Comment #10

webchick

she/they

English

Vancouver 🇨🇦

CreditAttribution: webchick commented 29 April 2006 at 00:28

Status:

Reviewed & tested by the community

» Fixed

Confirmed existence of problem, and chx's patch does indeed fix it.

I then went through and did my "click around to every bloody form I can think of" test -- created new account, logged in, messed w/ taxonomy, access control, etc. -- all looks good! RTBC.