meh.

CommentFileSizeAuthor
drupal.taxonomy-term-edit.patch4.58 KBsun
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

catch’s picture

catch
he/him
Primary language English
CreditAttribution: catch commented
Status: Needs review » Reviewed & tested by the community

Sexy.

Dries’s picture

Dries CreditAttribution: Dries commented
Status: Reviewed & tested by the community » Fixed

Committed to CVS HEAD. Thanks sun!

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

c960657’s picture

c960657 CreditAttribution: c960657 commented
Status: Closed (fixed) » Active

This patch also changed the tab label on taxonomy/term/1, so the tabs are no longer labeled “View” and “Edit term” but “View” and “foo” (with foo being the term name). I assume this wasn't intentional?

I'm not sure what the best way is to fix this, though. I guess using drupal_set_title() in taxonomy_form_term is a hack (because it is a form builder function, not a page callback).

BTW, if we want consistency with node.module, the tab title should be “Edit” (not “Edit term”) and the page title should be “Edit term foo”.

sun’s picture

sun
Primary language German
Location Karlsruhe
CreditAttribution: sun commented
Status: Active » Closed (fixed)

The same issue exists on user/% and a couple of other pages.

Hence, let's move this to a dedicated issue. If you find an existing or create a new one, linking to it from here would be highly appreciated.

dman’s picture

dman CreditAttribution: dman commented

Historically, the tab was (re)named “Edit term” not "Edit" due to conflicts with views. Term listing page taxonomy/term/n may commonly be owned by a view, which had also claimed a tab labelled 'Edit".
I imagine the same issue still applies?

Neat tidy-up btw sun.

c960657’s picture

c960657 CreditAttribution: c960657 commented

I just filed #635378: Wrong local task titles for taxonomy term and user account pages.