platform comparison doesn't handle properly non-global modules [#604800]

Here's my situation: I have a site (let's call it example.com) which installed the shiny new dev version of Zen in their sites/example.com/themes. So the site verifies right and is seen as having Zen 2.x. But the target platform has (rightfully) Zen 1.0. The migrate refuses to run because it thinks it would be a downgrade, which is actually false since the theme is in the sites/example.com directory.

Migrate should consider whether the module/theme is in the sites/example.com directory before refusing to upgrade.

Note that this is different than #595294: Migrate package comparison assumes 6.x-1.x-dev is older than 6.x-1.0 , which concerns only releases on the same branch.

Comments

Comment #1

anarcat CreditAttribution: anarcat commented 14 October 2009 at 23:00

Title:

platform comparison doesn't take into account higher versions of modules in sites/example.com/modules

» platform comparison doesn't handle properly non-global modules

a shorter and more appropriate name. there's also the issue that modules in sites/example.com are marked as missing if they are not in site/all, which is not quite true: they will be migrated along...

Comment #2

anarcat CreditAttribution: anarcat commented 14 October 2009 at 23:10

I guess we'll need verify to check if the package is in sites/all or in the site directory and add a flag in the database to carry that information... unless we guess based on the module path?

Comment #3

adrian CreditAttribution: adrian commented 15 October 2009 at 08:18

we could just do the check up to the profile level, and not on the site level. and just assume the modules in sites/all will move along

keep in mind you will not be upgrading these modules at all, ever through the aegir interface.

Comment #4

j0nathan CreditAttribution: j0nathan commented 25 March 2010 at 19:06

subscribing

Comment #5

anarcat CreditAttribution: anarcat commented 25 March 2010 at 19:36

Assigned:	Unassigned	» anarcat
Status:	Active	» Needs work

I'm working on a patch to ignore site-specific modules and themes in sites/example.com/ in the discovery code. We are not doing anything with those anyways and are generally conceptually ignored by aegir.