Early Bird Registration for DrupalCon Portland 2024 is open! Register by 23:59 PST on 31 March 2024, to get $100 off your ticket.
The SearchQuery::execute() method currently returns FALSE when the normalization query failed. This makes the rest of the database layer choke when, for example, you try to extend a SearchQuery-extended query by a PagerQuery.
Discussed with Larry on #drupal: the proper solution is to add a DatabaseStatementEmpty class that properly implement DatabaseStatementInterface.
Comment | File | Size | Author |
---|---|---|---|
#2 | empty-result.patch | 5.38 KB | Crell |
Comments
Comment #1
Dries CreditAttribution: Dries commentedThis makes sense to me. It sounds like it could be a relatively small change acceptable for D7.
Comment #2
Crell CreditAttribution: Crell commentedThis passes the relevant tests for me. Nice and simple.
Comment #3
Damien Tournoud CreditAttribution: Damien Tournoud commentedThat looks perfect to me, thanks Larry.
Comment #5
Crell CreditAttribution: Crell commentedStill green. This is DamZ's RTBC, not mine, I'm just verifying the bot. :-)
Comment #6
webchickCommitted to HEAD, with the addition of a @see SearchQuery, since I would otherwise have no idea what the heck you guys were talking about. ;) This is not really the fault of the description, though, which is accurate.