There is a *LOT* of outdated and inefficient things still in contact_menu including references to removed paths, etc. Once we hit our slush freeze, I want to get this cleaned up so it's actually helpful.

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Dave Reid’s picture

Title: Cleanup contact_help() » Cleanup contact.module

Actually there are a lot of general cleanups in the module. Instead of creating issues for each tiny cleanup, I'd rather have one issue for them. This will also be a coding standards check of the module.

Dave Reid’s picture

Title: Cleanup contact.module » Cleanup contact_help()

Ugh, a lot of the contact.module cleanups will be API changes, so this is going back to being about contact_help() only.

jhodgdon’s picture

This needs to be done before the string freeze, which is alpha release, which is coming up on Jan 15.

So what happened - now we cannot customize the text at the top of the contact form? Any guidance on why?

Dave Reid’s picture

Status: Active » Fixed

We got this as part of the past cleanup. I'll re-open if its not the case.

The text was moved to a 'Contact information' block instead of a setting in contact.module.

jhodgdon’s picture

Status: Fixed » Active

Um... The help text isn't updated that I can see. from contact_help():

    case 'admin/structure/contact':
      $output = '<p>' . t('Add one or more categories to set up your site-wide <a href="@form">contact form</a>. You can <a href="@settings">customize the information above the contact form</a> on the settings page.', array('@settings' => url('admin/structure/contact/settings'), '@form' => url('contact'))) . '</p>';   

The main help should also probably mention this block.

jhodgdon’s picture

Issue tags: +ui-text, +d7help

Where is this contact information block, anyway?

There is no hook_block() implementation in contact.module that I can see, and I don't see any Contact Information block in my D7 blocks admin page, although I have both Contact and Block modules enabled.

Dave Reid’s picture

It's created in the D6->D7 upgrade path in system.install if the contact information variable was not empty in D6. It's not provided by contact module or any other module by default. It's like you go and create a custom block, hence why its not documented in contact_help().

jhodgdon’s picture

So you think this is obvious and we don't need to document it for new users of Drupal 7 who might not think "Oh, I should just use a custom block"? I don't think it's obvious, and I think maybe we should at least put in the help somewhere that you can add or edit a block to put custom content there. And will all themes support putting a block at the top of the page? Not likely. Sigh.

Also, I don't see that functionality happening anywhere in contact.install. Can you point me to the function (apologies if I am being blind)?

jhodgdon’s picture

See also #677570: Help text for Contact form settings page is confusing, which I marked as duplicate of this issue.

Dave Reid’s picture

I never said it was obvious and I do want it documented. I'm just trying to answer your questions. :/

It's in system_update_7021() which was added in #240873: Move custom help settings to blocks which I had no part in. :/

jhodgdon’s picture

Status: Active » Needs review
FileSize
5.83 KB
30.76 KB
14.65 KB

Oh, system module. No wonder I didn't see it in the contact module (and I don't want to get into why it is in system and not contact, which makes very little sense to me, but whatever).

Thanks, now I at least understand what is going on, and don't worry, I'm not blaming you.

Here's a patch that modifies both the on-screen help for the Contact form config page ,and the main Contact module help page. See screen shots.

john_jacobs’s picture

Hi
(I am new here so please just ignore if this tiny comment is not useful)
Re: Subediting the use of commas on contact helppage
It's my understanding that a comma is not required before an and.
Cheers John

jhodgdon’s picture

john_jacobs: It is required, as per Drupal style guidelines. http://drupal.org/node/338208

Dries’s picture

Shouldn't 'Contact menu item' use a lower-case? It is not a page or anything?

jhodgdon’s picture

Status: Needs review » Needs work

It's a menu item that is called "Contact" in the Nav menu... But you're point is valid, and it didn't make sense as it was, having that be a link to the menu admin page (bad link text). So I think maybe that line should say:

"A Contact menu item (disabled by default) is added to the Navigation menu, which you can modify on the (link)Menus administration page(endlink)."

I'm not in a patching mood today...

Bojhan’s picture

Status: Needs work » Needs review
FileSize
5.97 KB

Changed it, this is ok?

jhodgdon’s picture

I think the EM needs to be just around Contact in "contact menu item" in the last section.

I also just noticed "on the site-wide contact form page"... form page? Maybe this should just say "on the site-wide contact page"? The same phrasing is also used above in the main module help.

jhodgdon’s picture

Status: Needs review » Needs work
jhodgdon’s picture

Status: Needs work » Needs review
FileSize
5.88 KB

Here's a patch with those two changes from #17.

jhodgdon’s picture

FileSize
14.07 KB
31.69 KB

Here are screen shots of the contact module help page, and the help at top of admin/structure/contact, for ease of reviewing.

lisarex’s picture

Status: Needs review » Reviewed & tested by the community

Reviewed the text in the screenshots/patch since I've MAMP issues. RTBC!!

webchick’s picture

Status: Reviewed & tested by the community » Fixed

Looks good! Committed to HEAD.

Status: Fixed » Closed (fixed)
Issue tags: -ui-text, -d7help

Automatically closed -- issue fixed for 2 weeks with no activity.