Early Bird Registration for DrupalCon Portland 2024 is open! Register by 23:59 PST on 31 March 2024, to get $100 off your ticket.
There is a *LOT* of outdated and inefficient things still in contact_menu including references to removed paths, etc. Once we hit our slush freeze, I want to get this cleaned up so it's actually helpful.
Comment | File | Size | Author |
---|---|---|---|
#20 | contacthelp.png | 31.69 KB | jhodgdon |
#20 | contactadmin.png | 14.07 KB | jhodgdon |
#19 | 599124again.patch | 5.88 KB | jhodgdon |
#16 | cleanup.contacthelp.patch | 5.97 KB | Bojhan |
#11 | setuppage.png | 14.65 KB | jhodgdon |
Comments
Comment #1
Dave ReidActually there are a lot of general cleanups in the module. Instead of creating issues for each tiny cleanup, I'd rather have one issue for them. This will also be a coding standards check of the module.
Comment #2
Dave ReidUgh, a lot of the contact.module cleanups will be API changes, so this is going back to being about contact_help() only.
Comment #3
jhodgdonThis needs to be done before the string freeze, which is alpha release, which is coming up on Jan 15.
So what happened - now we cannot customize the text at the top of the contact form? Any guidance on why?
Comment #4
Dave ReidWe got this as part of the past cleanup. I'll re-open if its not the case.
The text was moved to a 'Contact information' block instead of a setting in contact.module.
Comment #5
jhodgdonUm... The help text isn't updated that I can see. from contact_help():
The main help should also probably mention this block.
Comment #6
jhodgdonWhere is this contact information block, anyway?
There is no hook_block() implementation in contact.module that I can see, and I don't see any Contact Information block in my D7 blocks admin page, although I have both Contact and Block modules enabled.
Comment #7
Dave ReidIt's created in the D6->D7 upgrade path in system.install if the contact information variable was not empty in D6. It's not provided by contact module or any other module by default. It's like you go and create a custom block, hence why its not documented in contact_help().
Comment #8
jhodgdonSo you think this is obvious and we don't need to document it for new users of Drupal 7 who might not think "Oh, I should just use a custom block"? I don't think it's obvious, and I think maybe we should at least put in the help somewhere that you can add or edit a block to put custom content there. And will all themes support putting a block at the top of the page? Not likely. Sigh.
Also, I don't see that functionality happening anywhere in contact.install. Can you point me to the function (apologies if I am being blind)?
Comment #9
jhodgdonSee also #677570: Help text for Contact form settings page is confusing, which I marked as duplicate of this issue.
Comment #10
Dave ReidI never said it was obvious and I do want it documented. I'm just trying to answer your questions. :/
It's in system_update_7021() which was added in #240873: Move custom help settings to blocks which I had no part in. :/
Comment #11
jhodgdonOh, system module. No wonder I didn't see it in the contact module (and I don't want to get into why it is in system and not contact, which makes very little sense to me, but whatever).
Thanks, now I at least understand what is going on, and don't worry, I'm not blaming you.
Here's a patch that modifies both the on-screen help for the Contact form config page ,and the main Contact module help page. See screen shots.
Comment #12
john_jacobs CreditAttribution: john_jacobs commentedHi
(I am new here so please just ignore if this tiny comment is not useful)
Re: Subediting the use of commas on contact helppage
It's my understanding that a comma is not required before an and.
Cheers John
Comment #13
jhodgdonjohn_jacobs: It is required, as per Drupal style guidelines. http://drupal.org/node/338208
Comment #14
Dries CreditAttribution: Dries commentedShouldn't 'Contact menu item' use a lower-case? It is not a page or anything?
Comment #15
jhodgdonIt's a menu item that is called "Contact" in the Nav menu... But you're point is valid, and it didn't make sense as it was, having that be a link to the menu admin page (bad link text). So I think maybe that line should say:
"A Contact menu item (disabled by default) is added to the Navigation menu, which you can modify on the (link)Menus administration page(endlink)."
I'm not in a patching mood today...
Comment #16
Bojhan CreditAttribution: Bojhan commentedChanged it, this is ok?
Comment #17
jhodgdonI think the EM needs to be just around Contact in "contact menu item" in the last section.
I also just noticed "on the site-wide contact form page"... form page? Maybe this should just say "on the site-wide contact page"? The same phrasing is also used above in the main module help.
Comment #18
jhodgdonComment #19
jhodgdonHere's a patch with those two changes from #17.
Comment #20
jhodgdonHere are screen shots of the contact module help page, and the help at top of admin/structure/contact, for ease of reviewing.
Comment #21
lisarex CreditAttribution: lisarex commentedReviewed the text in the screenshots/patch since I've MAMP issues. RTBC!!
Comment #22
webchickLooks good! Committed to HEAD.