system_region_list() should use list_themes() instead of a direct db_query() [#591758]

Spin off from #591734: Reduce system table queries in the critical path. We already have the information available, saves a query on every page request.

Comment	File	Size	Author
#4	drupal_591758_system_theme_list_4_d6.patch	574 bytes	hefox
#4
	themes.patch	989 bytes	catch

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Comment #1

chx CreditAttribution: chx commented 30 September 2009 at 05:43

Status:

Needs review

» Reviewed & tested by the community

I am giving this the green light in the hope that stale static caching in list_themes can not cause more problems than we have already given that in D6 system_region_list had no reset and list_themes had so it surely is reset more than s_r_l.

Comment #2

Dries CreditAttribution: Dries commented 30 September 2009 at 12:35

Status:

Reviewed & tested by the community

» Fixed

Nice. Committed to CVS HEAD. Thanks.

Comment #3

14 October 2009 at 12:40

Status:

Fixed

» Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

Comment #4

hefox CreditAttribution: hefox commented 2 July 2012 at 23:09

File	Size
drupal_591758_system_theme_list_4_d6.patch	574 bytes

Hm, has needs backport to d6 tag, but wasn't. Is it no longer possible? (I'm a bit unclear on what can't be backported).

Well, anyhow, d6 updated patch, but not going to re-open cause unsure of ^.

Comment #5

hefox CreditAttribution: hefox commented 16 July 2012 at 21:07

Version:	7.x-dev	» 6.x-dev
Status:	Closed (fixed)	» Needs review

After noticing that there are performance patches still going in, figured I'd reopen this for d6

Comment #6

2 March 2016 at 22:18

Status:

Needs review

» Closed (outdated)

Automatically closed because Drupal 6 is no longer supported. If the issue verifiably applies to later versions, please reopen with details and update the version.