Database error when rendering comments in PostgreSQL [#58921]

After an upgrade from rc2 to rc3 I get this error when I create a blog entry and everytime I access the entry:
--------------------------------------------------------------------------------------------
* warning: pg_query(): Query failed: ERROR: column "c.status" must appear in the GROUP BY clause or be used in an aggregate function in /home/erl/www/drupal-4.7.0-rc3/includes/database.pgsql.inc on line 84.
* user warning: query: SELECT c.cid as cid, c.pid, c.nid, c.subject, c.comment, c.format, c.timestamp, c.name, c.mail, c.homepage, u.uid, u.name AS registered_name, u.picture, u.data, c.score, c.users, c.thread, c.status FROM comments c INNER JOIN users u ON c.uid = u.uid WHERE c.nid = 24 AND c.status = 0 GROUP BY c.cid, c.pid, c.nid, c.subject, c.comment, c.format, c.timestamp, c.name, c.mail, u.picture, c.homepage, u.uid, u.name, u.picture, u.data, c.score, c.users, c.thread ORDER BY c.thread DESC LIMIT 30 OFFSET 0 in /home/erl/www/drupal-4.7.0-rc3/includes/database.pgsql.inc on line 103.
--------------------------------------------------------------------------------------------

I use postgresql 8.1.3 with php.4.4.2

Comment	File	Size	Author
#5	comment.module.pgsql_fix_0.patch	1.25 KB	markus_petrux
#5
#3	comment.module.pgsql_fix.patch	978 bytes	markus_petrux
#3

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Comment #1

ralfm CreditAttribution: ralfm commented 15 April 2006 at 20:10

I have reverted to RC2 and restored a backup from RC2 and everything works without problmes with RC2.

Comment #2

markus_petrux CreditAttribution: markus_petrux commented 15 April 2006 at 20:32

Title:

Database error when seeing a blog entry

» Database error when rendering comments in PostgreSQL

I believe this is a problem with comment_render, introduced by this:
http://drupal.org/node/51002

Comment #3

markus_petrux CreditAttribution: markus_petrux commented 15 April 2006 at 20:47

Status:

Active

» Needs review

File	Size
comment.module.pgsql_fix.patch	978 bytes

I believe adding the c.status column to the GROUP BY clausule probably fixes the problem.

Comment #4

Cvbge CreditAttribution: Cvbge commented 16 April 2006 at 09:08

Hi Markus,

in your patch you add c.status to GROUP BY only for normal users (without administer comments right). Is that enough?
If someone has administer comments right he won't have c.status added to GROUP BY and I believe he will get the error.
Could you test it?

I think correct way would be to add c.status to GROUP BY in both cases.