Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
Here is a patch for giving the watchdog table an id to make it easier to style.
Comment | File | Size | Author |
---|---|---|---|
#12 | watchdog-table-id-58090-12.patch | 667 bytes | webchick |
#9 | 20070624_watchdogid.patch | 665 bytes | sime |
watchdog.id.patch | 629 bytes | sime | |
Comments
Comment #1
Stefan Nagtegaal CreditAttribution: Stefan Nagtegaal commentedI don't think this is the right way todo. IMO it would be far better to wrap every page in a div with a unique id, rather than doing it this way for ever element.
Maybe we could discuss this here so we (I?) can/could prepare a patch for drupal once HEAD is open for development again..
Steef
Comment #2
simeSounds fine by me. I just wanted to put it out there while the hack was fresh in my mind. :-)
Comment #3
Tobias Maier CreditAttribution: Tobias Maier commentedI hate it that we give everything an id
wouldnt be a class enough?
Comment #4
Stefan Nagtegaal CreditAttribution: Stefan Nagtegaal commentedClasses should be anough if the page content will be wrapped in a div with a unique id. but why do you hate the usage of id's?
Steef
Comment #5
Tobias Maier CreditAttribution: Tobias Maier commentedfor example you create a dashboard-site and put in for example two aggregator-pages or two profile listings...
and what do you have?
an id-conflict
this is followed by my second most hated problem: hardcoded html
I think that ids should only be used if reallyreallyreally necessary (maybe javascripts need it - but i'm no js-coder so i dont really know)
and directly in themes and not in modules or in drupal core
Comment #6
simeThat's an interesting case you present, I hadn't thought about that possibility.
Comment #7
sime.... except when would you have two watchdog tables for the one site? :-/
Comment #8
keith.smith CreditAttribution: keith.smith commentedNeeds rerolling to accommodate 6.x watchdog/dblog changes, at the very least.
Comment #9
simePatch rerolled.
I again considered the request for a classed div, but I don't see this being necessary. There is only one table on this page. You'd have to write your own page to gain multiple tables and then you'd obviously add your classes there.
Comment #10
simeComment #11
dmitrig01 CreditAttribution: dmitrig01 commentedthis works and well too
Comment #12
webchickSmall coding style error.
Comment #13
meba CreditAttribution: meba commentedseems ok
Comment #14
Gábor HojtsyComitted, thanks!
Comment #15
Gábor HojtsyComment #16
(not verified) CreditAttribution: commented