add id to dblog table [#58090]

Comment	File	Size	Author
#12	watchdog-table-id-58090-12.patch	667 bytes	webchick

#9	20070624_watchdogid.patch	665 bytes	sime

	watchdog.id.patch	629 bytes	sime

Comment #1

Stefan Nagtegaal CreditAttribution: Stefan Nagtegaal commented 10 April 2006 at 15:02

I don't think this is the right way todo. IMO it would be far better to wrap every page in a div with a unique id, rather than doing it this way for ever element.

Maybe we could discuss this here so we (I?) can/could prepare a patch for drupal once HEAD is open for development again..

Steef

Log in or register to post comments

Comment #2

sime

any/any

Melbourne

CreditAttribution: sime commented 10 April 2006 at 15:12

Sounds fine by me. I just wanted to put it out there while the hack was fresh in my mind. :-)

Log in or register to post comments

Comment #3

Tobias Maier CreditAttribution: Tobias Maier commented 10 April 2006 at 15:47

I hate it that we give everything an id
wouldnt be a class enough?

Log in or register to post comments

Comment #4

Stefan Nagtegaal CreditAttribution: Stefan Nagtegaal commented 10 April 2006 at 17:16

Classes should be anough if the page content will be wrapped in a div with a unique id. but why do you hate the usage of id's?

Steef

Log in or register to post comments

Comment #5

Tobias Maier CreditAttribution: Tobias Maier commented 10 April 2006 at 17:33

for example you create a dashboard-site and put in for example two aggregator-pages or two profile listings...
and what do you have?
an id-conflict
this is followed by my second most hated problem: hardcoded html

I think that ids should only be used if reallyreallyreally necessary (maybe javascripts need it - but i'm no js-coder so i dont really know)
and directly in themes and not in modules or in drupal core

Log in or register to post comments

Comment #6

sime

any/any

Melbourne

CreditAttribution: sime commented 30 August 2006 at 13:50

That's an interesting case you present, I hadn't thought about that possibility.

Log in or register to post comments

Comment #7

sime

any/any

Melbourne

CreditAttribution: sime commented 30 August 2006 at 14:21

.... except when would you have two watchdog tables for the one site? :-/

Log in or register to post comments

Comment #8

keith.smith CreditAttribution: keith.smith commented 23 June 2007 at 19:08

Version:	x.y.z	» 6.x-dev
Status:	Needs review	» Needs work

Needs rerolling to accommodate 6.x watchdog/dblog changes, at the very least.

Log in or register to post comments

Comment #9

sime

any/any

Melbourne

CreditAttribution: sime commented 24 June 2007 at 04:17

Title:

add id to watchdog table

» add id to dblog table

File	Size
20070624_watchdogid.patch	665 bytes

Patch rerolled.

I again considered the request for a classed div, but I don't see this being necessary. There is only one table on this page. You'd have to write your own page to gain multiple tables and then you'd obviously add your classes there.