with top border looks more consistency.
head background and border different in color. if missing a border on top will make you think that missing some pixels.

CommentFileSizeAuthor
#3 570994.jpg24.35 KBcodi
#2 570994-fix.patch694 bytescodi
without-top-border.PNG8.06 KBdroplet
with-lighter-top-border.PNG4.75 KBdroplet
with-top-border.PNG9.35 KBdroplet
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Bojhan’s picture

Bojhan CreditAttribution: Bojhan commented

The lighter one looks good.

codi’s picture

codi CreditAttribution: codi commented
Status: Active » Needs review
FileSize
570994-fix.patch694 bytes

first attempt at helping with d7.

added 1px border to top of tables.

patch attached.

codi’s picture

codi CreditAttribution: codi commented
FileSize
570994.jpg24.35 KB

screenshot for reference.

pixel border on thead>tr

yoroy’s picture

yoroy CreditAttribution: yoroy commented
Status: Needs review » Reviewed & tested by the community

yes that's the better one.

webchick’s picture

webchick
she/they
Primary language English
Location Vancouver 🇨🇦
CreditAttribution: webchick commented
Status: Reviewed & tested by the community » Fixed

Yeah, this does look really buggy now that you mention it.

Before:
now

After:
after

Committed to HEAD. Congratulations to codi on his first core patch! :D

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.