Destroy remnants of update_sql()

Oops, just created #570910: Return meaningful messages from update hooks for 1)

The update field tests are attempting to pass array() to db_drop_table().

field_sql_storage_field_storage_update_field() still has a couple of db_ function calls with $ret.

field_sql_storage_field_storage_update_field() was recently added in this commit: http://drupal.org/cvs?commit=267832 to modules/field/modules/field_sql_storage/field_sql_storage.module

Can't update the patch from here (firewall restriction), but the changes for field_sql_storage_field_storage_update_field() are:

@@ -231,17 +231,15 @@ function field_sql_storage_field_update_forbid($field, $prior_field, $has_data)
  * Implement hook_field_storage_update_field().
  */
 function field_sql_storage_field_storage_update_field($field, $prior_field, $has_data) {
-  $ret = array();
-
   if (! $has_data) {
     // There is no data. Re-create the tables completely.
     $prior_schema = _field_sql_storage_schema($prior_field);
     foreach ($prior_schema as $name => $table) {
-      db_drop_table($ret, $name, $table);
+      db_drop_table($name, $table);
     }
     $schema = _field_sql_storage_schema($field);
     foreach ($schema as $name => $table) {
-      db_create_table($ret, $name, $table);
+      db_create_table($name, $table);
     }
   }
   else {
@@ -253,8 +251,8 @@ function field_sql_storage_field_storage_update_field($field, $prior_field, $has
     foreach ($prior_field['indexes'] as $name => $columns) {
       if (!isset($field['indexes'][$name]) || $columns != $field['indexes'][$name]) {
         $real_name = _field_sql_storage_indexname($field['field_name'], $name);
-        db_drop_index($ret, $table, $real_name);
-        db_drop_index($ret, $revision_table, $real_name);
+        db_drop_index($table, $real_name);
+        db_drop_index($revision_table, $real_name);
       }
     }
     $table = _field_sql_storage_tablename($field);
@@ -266,8 +264,8 @@ function field_sql_storage_field_storage_update_field($field, $prior_field, $has
         foreach ($columns as $column_name) {
           $real_columns[] = _field_sql_storage_columnname($field['field_name'], $column_name);
         }
-        db_add_index($ret, $table, $real_name, $real_columns);
-        db_add_index($ret, $revision_table, $real_name, $real_columns);
+        db_add_index($table, $real_name, $real_columns);
+        db_add_index($revision_table, $real_name, $real_columns);
       }
     }
   }

quick, someone commit this before it breaks :D

I really want to commit this, but unfortunately the system.install hunk no longer applies. :( I can haz reroll?

Looks good -- less is more. Committed to CVS HEAD. Thanks!

In past we haven't used t() in hook_update for the simple reason that translatable strings are not yet imported while running the update hooks and therefore never shown translated. Anything changed about this behaviour?

Is there a reason why system_update_N() all still have '$ret's all over the place ?

Changes look good. Besides deleting the strict-BC code in update_do_one, we could also rework the rest of the function that is still globally designed around the old format.

      $ret['results']['query'] = $function($context['sandbox']);
      $ret['results']['success'] = TRUE;

Not critical, though.

Committed to CVS HEAD. Thanks!