There is no provision for changing toggle_logo from the default.
The attached patch for system.module will add the setting for toggle_logo.

--- details ---
In the themes distributed with Drupal (4.7.0 rc1) the variable $logo is tested for inclusion of the logo. However, $logo is a string and always contains a path value; therefore it is always TRUE.

$logo is set by calling theme_get_setting('logo') in line 197 of the phptemplate.engine.

theme_get_setting() returns the value for 'logo' in this block starting at line 299 of theme.inc this block tests for $settings['toggle_logo'] which is set to a default setting of 1 in the function theme_get_settings().

    if ($settings['toggle_logo']) {
      $settings['logo'] = base_path();
      if ($settings['default_logo']) {
        $settings['logo'] .= dirname($theme_object->filename) .'/logo.png';
      }
      elseif ($settings['logo_path']) {
        $settings['logo'] .= $settings['logo_path'];
      }
    }

so toggle_logo is always TRUE and $logo will always have a path .....

CommentFileSizeAuthor
#1 toggle_logo.patch7.92 KBSteven
toggle_logo.patch.txt465 bytesjsloan
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Steven’s picture

Title: No toggle_logo setting available in the system settings » Add toggle_logo, make theme settings more usable
FileSize
7.92 KB

There were some issues with this patch. The biggest one being that theme engines implement the "logo" feature and not the "toggle_logo" feature. So the toggle did not show up on the individual theme pages (only on the global settings). I replaced the "logo" feature by "toggle_logo" for consistency.

However, IMO the resulting UI is confusing. We have a setting for a logo and a favicon at the top, but it is not immediately obvious that you need to turn on the relevant toggles far at the bottom for them to take effect.

So I did some quick rearranging. Now the toggles are displayed at the top (and side-by-side) while the more specific logo/favicon settings are shown below. The page hierarchy is much clearer now IMO (image).

Finally I tweaked the code so that the logo resp. favicon toggle is turned on automatically if you upload a logo resp. favicon image.

Steven’s picture

Status: Needs review » Fixed

Committed to HEAD (after a quick check by Gerhard).

Anonymous’s picture

Status: Fixed » Closed (fixed)