the user authenticate cleanup is broken here. I have removed one case, because the installer already add user 1, the other simply was broken.

CommentFileSizeAuthor
#3 user_registration_565290-3.patch17.04 KBfloretan
#1 user_registration_565290.patch17.04 KBfloretan
user_register.patch6.23 KBchx
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

floretan’s picture

floretan CreditAttribution: floretan commented
FileSize
user_registration_565290.patch17.04 KB

Fix a little error ($form_state needs to have 'uid' set before it gets passed to user_login_submit()) and rewrite the user registration test for a more complete coverage of different configurations.

Status: Needs review » Needs work

The last submitted patch failed testing.

floretan’s picture

floretan CreditAttribution: floretan commented
Status: Needs work » Needs review
FileSize
user_registration_565290-3.patch17.04 KB

Re-rolled the patch. No real changes to the code.

roychri’s picture

roychri CreditAttribution: roychri commented
Status: Needs review » Reviewed & tested by the community

The code looks clean. It seem to follow the coding standards. It passes the simpletest and my own tests.
This looks good.

Dries’s picture

Dries CreditAttribution: Dries commented
Status: Reviewed & tested by the community » Fixed

Commited to CVS HEAD. Thanks.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

drupal_was_my_past’s picture

drupal_was_my_past CreditAttribution: drupal_was_my_past commented

Marked #565924: Remove code for user 1 creation from user_register_submit() as a duplicate.