Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.The cron.php will run regardless of whether the site is in maintenance mode or not. This could potentially cause problems when doing module updates.. I propose that cron.php skip a run if it's called when the site is in maintenance mode.
-Myke
| Comment | File | Size | Author |
|---|---|---|---|
| #13 | cron-565154.patch | 984 bytes | klausi |
| #9 | cron-565154.patch | 1.04 KB | klausi |
| #5 | cron-565154.patch | 1.04 KB | klausi |
| #3 | cron_565154_dont_run_maintenance_mode.patch | 1.23 KB | matason |
| #2 | cron_565154_dont_run_maintenance_mode.patch | 1.27 KB | matason |
Comments
Comment #1
myke CreditAttribution: myke commentedComment #2
matason CreditAttribution: matason commentedI'm not sure about the argument put forth here but I was able to create the attached patch in case it's helpful...
Comment #3
matason CreditAttribution: matason commentedSorry, this is the correct patch, don't know how to remove the other.
Comment #4
attiks CreditAttribution: attiks commentedSeems like a good idea to me, for the same reason, not breaking upgrade.
Patch applies fine.
Comment #5
klausiShorter patch.
Comment #7
klausiHEAD was broken? OK Bot, then try again.
Comment #8
matason CreditAttribution: matason commentedThis approach is cleaner, applied and tested okay for me. Only issue I can see is that it creates an extra blank line at the end of the file.
Comment #9
klausiThank you very much for nitpicking! ;-)
Patch without blank at the end attached.
Comment #10
klausi... and to be reviewed.
Comment #12
fago+1 for that.
@patch: The comments should start upper case and end with a point. Anyway I think they should be removed as they say nothing more than the actual code below.
Comment #13
klausiPatch should apply now, useless comments are removed.
Comment #14
fagoGreat, code looks good now. I 've just tested it properly and it's also working fine, so I think it's ready.
Comment #16
matason CreditAttribution: matason commentedThe patch still looks and applies okay for me. The reported fail is something to do with database tests.
Comment #17
webchickThis seems like a sensible change. The extra watchdogs to provide additional debugging info are a nice touch.
Committed to HEAD! Thanks!