Looking at _taxonomy_depth(), I think this could easily be replaced by faster str_repeat().
As you probably know, php function lookup is slow. Furthermore, you perform it in a potentially large loop. And the php code in _taxonomy_depth() doesn't do anything str_repeat() can't do.

CommentFileSizeAuthor
#4 taxonomy_depth_forums.patch1.49 KBwebchick
#2 notaxdepth.patch1.88 KBchx
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Egon Bianchet’s picture

Egon Bianchet CreditAttribution: Egon Bianchet commented
Version: 4.7.0-beta6 » 4.7.0
chx’s picture

chx CreditAttribution: chx commented
Version: 4.7.0 » x.y.z
Assigned: Unassigned » chx
Category: bug » task
Priority: Normal » Minor
Status: Active » Reviewed & tested by the community
FileSize
notaxdepth.patch1.88 KB

You are just right.

Dries’s picture

Dries CreditAttribution: Dries commented
Status: Reviewed & tested by the community » Fixed

Committed to CVS HEAD. Thanks.

webchick’s picture

webchick
she/they
Primary language English
Location Vancouver 🇨🇦
CreditAttribution: webchick commented
Category: task » bug
Priority: Minor » Critical
Status: Fixed » Needs review
FileSize
taxonomy_depth_forums.patch1.49 KB

This broke forums.

Jaza’s picture

Jaza CreditAttribution: Jaza commented
Status: Needs review » Reviewed & tested by the community

Confirmed. I get a blank page at 'admin/content/forum'.

Tested Webchick's patch (above), and it fixes the problem.

drumm’s picture

drumm
he/him
Location NY, US
CreditAttribution: drumm commented
Status: Reviewed & tested by the community » Fixed

Doesn't look pretty, but I guess it didn't before. Committed to HEAD.

Anonymous’s picture

(not verified) CreditAttribution: commented
Status: Fixed » Closed (fixed)