As #545662-39: Simplify field rendering showed, test bot (or some slaves ?) don't always run all Fiald Attach Tests, and report patches as green while there are failures.

Anyone is able to submit a patch that badly breaks Field API and get it committed :-p.

One possible explanation could be that Field Attach Tests are *very* heavy, and explodes on some localhosts (including mine, but mine's crappy, that's not a sign)

Attached patch splits FieldAttachTestCase() in two classes (storage-related and others). That split will probably make sense in the future as well, because storage-related tests are a great proof test for alternate storage engines, and those tests could be reused somehow.

CommentFileSizeAuthor
#11 field_attach_tests-559486-10.patch816 bytesyched
#10 field_attach_test-559486-10.patch816 bytesplach
#4 field_attach_test-559486-4.patch860 bytesplach
#1 field_attach_tests.patch22.59 KByched
field_attach_tests.patch24.01 KByched
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

yched’s picture

yched CreditAttribution: yched commented
FileSize
field_attach_tests.patch22.59 KB

Hm, less utterly broken this time.

bjaspan’s picture

bjaspan CreditAttribution: bjaspan commented
Status: Needs review » Reviewed & tested by the community

Easy review, looks good.

webchick’s picture

webchick
she/they
Primary language English
Location Vancouver 🇨🇦
CreditAttribution: webchick commented
Status: Reviewed & tested by the community » Fixed

Committed to HEAD. Thanks!

plach’s picture

plach
he/him
Primary language Italian
Location Venezia
CreditAttribution: plach commented
Status: Fixed » Needs review
FileSize
field_attach_test-559486-4.patch860 bytes

On my box field translation tests are failing:

Fatal error: Call to undefined function _generateTestFieldValues() in E:\www\test\modules\field\field.test on line 2087

There is a missing $this-> while calling _generateTestFieldValues().

sun’s picture

sun
Primary language German
Location Karlsruhe
CreditAttribution: sun commented
Status: Needs review » Reviewed & tested by the community

Sounds sane.

Status: Reviewed & tested by the community » Needs work

The last submitted patch failed testing.

plach’s picture

plach
he/him
Primary language Italian
Location Venezia
CreditAttribution: plach commented
Status: Needs work » Reviewed & tested by the community

Head was broken. Re-testing.

yched’s picture

yched CreditAttribution: yched commented

Oops, sorry about this plach. Strange this didn't get reported. I though testbot now reported fatal errors ?

webchick’s picture

webchick
she/they
Primary language English
Location Vancouver 🇨🇦
CreditAttribution: webchick commented
Status: Reviewed & tested by the community » Needs work

For some reason I can't apply this:

webchicks-macbook-pro:core webchick$ patch -p0 < field_attach_test-559486-4.patch 
patch: **** Only garbage was found in the patch input.

Could someone re-roll?

And yes, wtf @ testing bot not catching this. :(

plach’s picture

plach
he/him
Primary language Italian
Location Venezia
CreditAttribution: plach commented
Status: Needs work » Reviewed & tested by the community
FileSize
field_attach_test-559486-10.patch816 bytes

rerolled

yched’s picture

yched CreditAttribution: yched commented
FileSize
field_attach_tests-559486-10.patch816 bytes

Odd, #4 applies for me. Rerolled.

webchick’s picture

webchick
she/they
Primary language English
Location Vancouver 🇨🇦
CreditAttribution: webchick commented
Status: Reviewed & tested by the community » Fixed

Thanks, all. Committed to HEAD.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.