There is some JavaScript code in modules/system/system.js that includes some trailing commas after object property definitions. Non-IE browsers do not care about these commas, but IE considers them to be a syntax error and will bail out on the entire JS file. Most users won't even notice this, but I happened to have JS debugging turned on in IE and got a lovely white screen with a error message. An image is attached.
I'll roll a patch later today or someone else can since it's such a small change.
For those unsure of what I'm talking about, see the bolded code below. What I'm referring to is the isolated "}," on the second to last line in the two examples.
Drupal.behaviors.userTimeZones = {
attach: function (context, settings) {
$('#empty-timezone-message-wrapper .description').hide();
$('#edit-configurable-timezones', context).change(function () {
$('#empty-timezone-message-wrapper').toggle();
});
},
};
Drupal.behaviors.pageCache = {
attach: function (context, settings) {
$('#edit-cache-0', context).change(function () {
$('#page-compression-wrapper').hide();
$('#cache-error').hide();
});
$('#edit-cache-1', context).change(function () {
$('#page-compression-wrapper').show();
$('#cache-error').hide();
});
$('#edit-cache-2', context).change(function () {
$('#page-compression-wrapper').show();
$('#cache-error').show();
});
},
};
Comment | File | Size | Author |
---|---|---|---|
#5 | ie-js-fix.patch | 1.15 KB | CalebD |
#1 | system.js-ie-comma.patch | 696 bytes | CalebD |
system.js-error-ie.small_.png | 17.64 KB | CalebD |
Comments
Comment #1
CalebD CreditAttribution: CalebD commentedPatch attached. Pretty straight forward.
Comment #2
CalebD CreditAttribution: CalebD commentedNow with delicious tags!
Comment #3
Damien Tournoud CreditAttribution: Damien Tournoud commentedMake sense.
@CalebD: could you check the other javascript files to see if we have this type of issue elsewhere?
Comment #4
CalebD CreditAttribution: CalebD commentedmisc/ajax.js also has the same problem on line 99. Will have a patch shortly.
Comment #5
CalebD CreditAttribution: CalebD commentedUpdated patch.
Comment #6
CalebD CreditAttribution: CalebD commentedBetter title.
Comment #7
cwgordon7 CreditAttribution: cwgordon7 commentedLooks great, awesome!
Comment #8
Dries CreditAttribution: Dries commentedCommitted to CVS HEAD. Thanks!