The control to assign a theme to a specific user seems to have disappeared.

A superuser visiting the user edit form at http://[domain-name]/user/[uid]/edit should see a list of enabled themes, and be able to select which one the user sees.

Likewise, the user should be able to make that selection as well, if the "Select different theme" permission is enabled.

Neither case seems to be true.

Marked "critical" per emmajane's suggestion in IRC. Good luck!

CommentFileSizeAuthor
#2 user-themes.patch2.15 KBemmajane
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

emmajane’s picture

Issue tags: +Novice

Talking to webchick in IRC confirms this feature has been removed. The permission; however, is still available. The permission needs to be removed from ?q=admin/settings/permissions. Assuming it's trivial to remove permissions, I've marked this patch as Novice as well.

emmajane’s picture

FileSize
2.15 KB

Then again, I may as well just roll this patch myself. :)

1. removes the permission for user themes
2. updates the text on ?q=admin/appearance

It's unclear to me if the "Enabled" checkbox is still needed on admin/appearance. Specifically line 1296 of system.module refers to enabled themes. I've left in this checkbox in case it is being used somewhere that I'm not aware of.

emmajane’s picture

Status: Active » Needs review

Marking patch as "needs review"

tgeller’s picture

Title: Can't change theme for a specific user » Need to remove "Select different theme" permission
Status: Needs review » Active
tgeller’s picture

Status: Active » Needs review
drifter’s picture

Status: Needs review » Reviewed & tested by the community

Simple patch, the wording seems good, it's ready IMHO.

kaakuu’s picture

The community has not reviewd it. I am afraid the community does not even know that this feature is being removed. All popular sites in the internet allows users to choose the skin they want, and letting an user (registered visitor to a site) choose a skin is only possible if theme-select options are available to the user.

Apart from that

How do I let an user choose a theme that has better accessibilty design ?
How do I let an user choose a theme if he is on roaming and wants a mobile theme ?

These need to be in core.

tgeller’s picture

kaakuu:

I'm afraid you missed the bus on this one: It's been discussed for over a year at http://drupal.org/node/292253 . The skinning feature will be removed from core, that much is certain. This issue is just to remove the permission setting, which now does nothing.

(I actually agree with you, but hey: I should have taken part in the earlier discussion. The community has spoken. The function will still be available in other forms, for example through the devel module.)

kaakuu’s picture

@tegller Thanks. An user missing a feature which has been so there long is more important than the fictitious bus :)

The last note on the same issue was "The permission was not removed indeed." So I thought that the bus left intact with all the passengers :)

Suddenly this seems to be getting through 'back-door'. An important feature which has been in core and does not affect its minimalism or light-weightedness needs MORE discussion and community participation.

It ALSO does not answer how it can be user friendly when you do not allow users to have a choice of their colors, that dictatorship is still OK but what about (repeating for emphasis)
How to let users choose a theme that has better accessibilty design ?
How to let users choose a theme if he is on roaming and wants a mobile theme ?

Please someone answer this.

Certainly registered site members are not going to have devel module, and if this can be left for a contrib better than wasting time on a destroying a standard feature, create a contrib that optionally removes it :)

‘‘I actually agree with you’’ - So please voice that and move in that direction. Why not ?

emmajane’s picture

@kaakuu Please make sure you are posting comments that are relevant to the patch at hand. If you do not want the user-themes removed this is not the place to discuss it. Please post those comments at #292253: Remove the per-user themes selection from core.

webchick’s picture

Status: Reviewed & tested by the community » Fixed

Indeed. This is a straight-forward clean-up from the other issue.

Committed to HEAD. Thanks.

kaakuu’s picture

@emmajnae - Thanks. I was discussing ‘‘Need to remove "Select different theme" permission’’
If the permission is not there how can I allow contribs to offer or not offer this feature to all auth users or selected groups ? In other words, the contrib available do not offer permission feature but utilises the permission feature of core. Without this being available many sites will have this feature broken. Imho, the patch needs to address this. This is my understanding - I may be wrong. But undoubtedly this is causing confusion and will cause more when the community (not developers) come to know of this.

webchick’s picture

@kaaku: The contributed module that implements this feature in one form or another would simply expose its own permission (or possibly several, for lots of additional flexibility).

Core exposing a permission that it doesn't use is just a bug, plain and simple.

kaakuu’s picture

We don't want to get all over it again, do we ?
This permission is extremely well used at least from our angle - it works extermely well and there has not been any significant bug report from those who use Drupal (except may be one or three devs)
If its a bug, to repeat, kill the bug not the feature!
It works fantastically, is not broken and needed on many sites.Period.

The contributed module that implements this feature in one form or another would simply expose its own permission

There is difference between "would" and "has done". Last time I saw there was not even any D7 pledge from such a module.It will mean hell lot of a problem if we want to upgrade and an extra module to look after. There is NOT even a list on D org that enlists such long standing features which are being removed in the "new" Drupal.
Anyway I quit. Thanks.

webchick’s picture

We don't want to get all over it again, do we ?

Nope. We sure don't. Especially not with 6 days left until code freeze and many critical improvements left to go. But in any case, such discussion is OT here; this patch is merely a clean-up issue. The place to further discuss this decision would be in #292253: Remove the per-user themes selection from core, although I thought you'd agreed there already to respect the decision and let it drop. :\

There is NOT even a list on D org that enlists such long standing features which are being removed in the "new" Drupal.

Yes, the list of changes from Drupal 6 to Drupal 7 may be found in CHANGELOG.txt, including the fact that this and other features were removed from core this release.

Status: Fixed » Closed (fixed)
Issue tags: -Novice

Automatically closed -- issue fixed for 2 weeks with no activity.