Submit handler was not fully updated to 'per context weights' API feature.

CommentFileSizeAuthor
#6 field_ui_wipe_weights-554290-6.patch958 bytesyched
#1 field_ui_wipe_weights.patch958 bytesyched
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

yched’s picture

yched CreditAttribution: yched commented
FileSize
field_ui_wipe_weights.patch958 bytes

I could swear I uploaded a patch...

Status: Needs review » Needs work

The last submitted patch failed testing.

webchick’s picture

webchick
she/they
Primary language English
Location Vancouver 🇨🇦
CreditAttribution: webchick commented
Status: Needs work » Needs review

Oh, testing bot...

Status: Needs review » Needs work

The last submitted patch failed testing.

yched’s picture

yched CreditAttribution: yched commented

Fail on 'Top visitor blocking' test ?? Must be a bot trick...

yched’s picture

yched CreditAttribution: yched commented
Status: Needs work » Needs review
FileSize
field_ui_wipe_weights-554290-6.patch958 bytes

Let's try a re-test.

webchick’s picture

webchick
she/they
Primary language English
Location Vancouver 🇨🇦
CreditAttribution: webchick commented
Status: Needs review » Needs work
Issue tags: +Needs tests

Technically this is still in "needs review" but it seems like a straight-forward fix (which probably means it breaks everything.. ;P)

Committed to HEAD. Marking needs work because we should provide test coverage on this.

sun.core’s picture

sun.core CreditAttribution: sun.core commented
Priority: Critical » Normal

Tests don't qualify as critical.

mtift’s picture

mtift
he/him
Primary language English
Location Minnesota, USA
CreditAttribution: mtift commented
Status: Needs work » Needs review

I'm not sure that this patch applies anymore. I did a "cvs annotate" and didn't see any record of this patch. I tried to apply it and got a "hunk FAILED."

cleaver’s picture

cleaver CreditAttribution: cleaver commented
Status: Needs review » Needs work

Patch won't apply.

Tor Arne Thune’s picture

Tor Arne Thune CreditAttribution: Tor Arne Thune commented
Title: Fields weights lost on display when submitting 'Display fields' screen » (Tests needed) Fields weights lost on display when submitting 'Display fields' screen
Version: 7.x-dev » 8.x-dev
Category: bug » task
Issue tags: +Needs backport to D7
swentel’s picture

swentel CreditAttribution: swentel commented
Version: 8.x-dev » 7.x-dev
Issue summary: View changes
Issue tags: -Needs backport to D7

Doesn't apply anymore for D8 - weights are now saved in the entity display (for which we have tests)

  • webchick committed 839c242 on 8.3.x 
    #554290 by yched: Fixed lost field weights when submitting 'Display...

  • webchick committed 839c242 on 8.3.x 
    #554290 by yched: Fixed lost field weights when submitting 'Display...

  • webchick committed 839c242 on 8.4.x 
    #554290 by yched: Fixed lost field weights when submitting 'Display...

  • webchick committed 839c242 on 8.4.x 
    #554290 by yched: Fixed lost field weights when submitting 'Display...

  • webchick committed 839c242 on 9.1.x 
    #554290 by yched: Fixed lost field weights when submitting 'Display...