Moreover: Submission URL is not updated with placeholder [#550702]

Comment	File	Size	Author
#5	xmlsitemap_fix_wrong_variable_named_morover_url-D6.patch	1.37 KB	hass

#3	xmlsitemap_fix_wrong_variable_named_morover_url-D6.patch	1.37 KB	hass

#2	xmlsitemap_fix_wrong_variable_named_morover_url-D6.patch	1.32 KB	hass

Comment #1

Anonymous (not verified) CreditAttribution: Anonymous commented 17 August 2009 at 12:56

Status:

Active

» Postponed (maintainer needs more info)

Not that I see from the code. The variables are set during xmlsitemap_engines_update_6100 in rather emphatic fashion. I.E. If the hook_update_N executed the value should be as you stated.

Log in or register to post comments

Comment #2

hass CreditAttribution: hass commented 17 August 2009 at 17:55

Status:

Postponed (maintainer needs more info)

» Needs review

File	Size
xmlsitemap_fix_wrong_variable_named_morover_url-D6.patch	1.32 KB

Typo in variable name. See patch attached.

Log in or register to post comments

Comment #3

hass CreditAttribution: hass commented 17 August 2009 at 18:03

File	Size
xmlsitemap_fix_wrong_variable_named_morover_url-D6.patch	1.37 KB

New patch... old one has a bug in the names.

Log in or register to post comments

Comment #4

apaderno

he/him

Italian

Brescia, 🇮🇹 🇪🇺

CreditAttribution: apaderno commented 17 August 2009 at 18:05

Status:

Needs review

» Needs work

It should be better if the code would rename the Drupal variable; differently, a custom value set by the user would be lost.

Log in or register to post comments

Comment #5

hass CreditAttribution: hass commented 17 August 2009 at 18:06

Status:

Needs work

» Needs review

File	Size
xmlsitemap_fix_wrong_variable_named_morover_url-D6.patch	1.37 KB

Oh my goodness... this cut and paste hell...

Log in or register to post comments

Comment #6

apaderno

he/him

Italian

Brescia, 🇮🇹 🇪🇺

CreditAttribution: apaderno commented 17 August 2009 at 18:11

Status:

Needs review

» Needs work

 /**
  * Delete wrongly named variable xmlsitemap_engines_morover_url.
  */
function xmlsitemap_engines_update_6109() {
  $ret = array();
  variable_set('xmlsitemap_engines_moreover_url', variable_get('xmlsitemap_engines_morover_url', 'http://api.moreover.com/ping?u=[sitemap]'));
  variable_del('xmlsitemap_engines_morover_url');
  return $ret;
}

As the module allows the user to change the value of xmlsitemap_engines_moreover_url, it would be better to use the last value inserted by the user.

Log in or register to post comments

Comment #7

hass CreditAttribution: hass commented 17 August 2009 at 18:12

Status:

Needs work

» Needs review

I believe we are not able to keep the "custom" value as it's still broken (no placeholder) from install. See intro...

Log in or register to post comments

Comment #8

hass CreditAttribution: hass commented 17 August 2009 at 18:19

Aside - I could also ask why the module overwrites my "custom" D5 settings... if I'm nitpicking... but I don't do it as the placeholder is better than my site's url...

Log in or register to post comments

Comment #9

Anonymous (not verified) CreditAttribution: Anonymous commented 19 August 2009 at 14:10

Status:

Needs review

» Fixed

Patch committed to CVS.

I will remove the ability to change the URL in version 1.1. I do not see a good reason to allow this setting to be changed. And hass, your nitpick complaint is one of mine as well. But it has been that way for a while and more than half of the 5.x users are using the development versions. I.E.: In my opinion it isn't worth fixing at this point in time.

Thanks for the fix to the misspelled variable.

Log in or register to post comments

Comment #10

hass CreditAttribution: hass commented 19 August 2009 at 14:46

Why not adding the form attribute '#disabled' for 1.0... may receive the complains - why this setting has been disabled and then finally decide or not - to remove the fields from view in 1.1 :-)

Log in or register to post comments

Comment #11

Dave Reid

he/him

English

Nebraska USA

CreditAttribution: Dave Reid commented 19 August 2009 at 15:45

@hass: See the discussion in #464980: Remove search engine authentication/verification code. It's silly that we allow users to be able to change the engine submission URLs. If anything we should give them a textarea to add any 'custom' submission URLs like in 6.x-2.x. Allowing users to change the engine URLs is just asking for trouble like this.