Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
After upgrading from 5.x-1.6 I've found this wrong value in the submission input box on "admin/settings/xmlsitemap/engines":
http://api.moreover.com/ping?u=http://www.example.com/sitemap.xml
But it should be
http://api.moreover.com/ping?u=[sitemap]
I cannot remember that I have ever touched this field myself, so I expect this is an upgrade bug.
Comment | File | Size | Author |
---|---|---|---|
#5 | xmlsitemap_fix_wrong_variable_named_morover_url-D6.patch | 1.37 KB | hass |
#3 | xmlsitemap_fix_wrong_variable_named_morover_url-D6.patch | 1.37 KB | hass |
#2 | xmlsitemap_fix_wrong_variable_named_morover_url-D6.patch | 1.32 KB | hass |
Comments
Comment #1
Anonymous (not verified) CreditAttribution: Anonymous commentedNot that I see from the code. The variables are set during xmlsitemap_engines_update_6100 in rather emphatic fashion. I.E. If the hook_update_N executed the value should be as you stated.
Comment #2
hass CreditAttribution: hass commentedTypo in variable name. See patch attached.
Comment #3
hass CreditAttribution: hass commentedNew patch... old one has a bug in the names.
Comment #4
apadernoIt should be better if the code would rename the Drupal variable; differently, a custom value set by the user would be lost.
Comment #5
hass CreditAttribution: hass commentedOh my goodness... this cut and paste hell...
Comment #6
apadernoAs the module allows the user to change the value of xmlsitemap_engines_moreover_url, it would be better to use the last value inserted by the user.
Comment #7
hass CreditAttribution: hass commentedI believe we are not able to keep the "custom" value as it's still broken (no placeholder) from install. See intro...
Comment #8
hass CreditAttribution: hass commentedAside - I could also ask why the module overwrites my "custom" D5 settings... if I'm nitpicking... but I don't do it as the placeholder is better than my site's url...
Comment #9
Anonymous (not verified) CreditAttribution: Anonymous commentedPatch committed to CVS.
I will remove the ability to change the URL in version 1.1. I do not see a good reason to allow this setting to be changed. And hass, your nitpick complaint is one of mine as well. But it has been that way for a while and more than half of the 5.x users are using the development versions. I.E.: In my opinion it isn't worth fixing at this point in time.
Thanks for the fix to the misspelled variable.
Comment #10
hass CreditAttribution: hass commentedWhy not adding the form attribute '#disabled' for 1.0... may receive the complains - why this setting has been disabled and then finally decide or not - to remove the fields from view in 1.1 :-)
Comment #11
Dave Reid@hass: See the discussion in #464980: Remove search engine authentication/verification code. It's silly that we allow users to be able to change the engine submission URLs. If anything we should give them a textarea to add any 'custom' submission URLs like in 6.x-2.x. Allowing users to change the engine URLs is just asking for trouble like this.
Comment #12
Anonymous (not verified) CreditAttribution: Anonymous commentedI've created #553930: Disable the UI for search engine URL for the #disable patch.