Author block doesn't obey settings

i'm not sure i agree that this is critical, but i can definitely reproduce the bug, and i'm attaching a trivial (2 line) fix. basically, inside profile.module's profile_block() method, where we're deciding what fields to display when viewing the block, we're trying to compare the fields against the settings saved in the DB via the block config page you mentioned in your post. b/c these settings are checkboxes, we store an array of all the field names, with 0's as the value for unchecked fields, and the field name as the value for the checked ones. so, when we compared using in_array(), everything matched, since every possible field name is in the array. the solution is to just see if that particular field has a non-0 value in the array. look at the diff if this isn't clear...

enjoy,
-derek

i just realized i was needlessly including " marks around $record->name when using it as an array index. the attached patch removes these (both versions work, this one is slightly better)...

i wonder if this bug was introduced by the FAPI conversion. are there other places we're storing a serialized array of checkboxes as a setting that in 4.6 used to only have entries for checked boxes, but in 4.7 has 0'ed entries for all boxes? i'd have to investigate more, but if anyone more familiar with core cared to comment, that'd be swell.

thanks,
-derek

Simpyl using an array index will throw warnings in php5, I think. Prefix the usage by isset($array['field']) &&

i use php4 everywhere... thanks for the heads-up on compatibility issues!

new version attached with isset().

whoops, i went backwards on the " problem. sorry about that. here's the (hopefully final, RTBC) patch.

applied