form_builder checkbox/textfield/validation stuff [#53967]

Comment	File	Size	Author
#5	fb_1.patch	1.22 KB	chx

#2	fb_0.patch	1.19 KB	hunmonk

#1	fb.patch	1.06 KB	hunmonk

	f_0.patch	488 bytes	chx

Comment #1

hunmonk CreditAttribution: hunmonk commented 14 March 2006 at 16:22

Assigned:	chx	» hunmonk
Status:	Reviewed & tested by the community	» Needs review

File	Size
fb.patch	1.06 KB

a couple other adjustments are necessary, as this was primarily done to help support multipart node forms. the following additions correct misfired validation errors on multiple stage node forms when they add new required fields on subsequent stages. this fixes the current project module bug on the second stage of the issue submission form, specifically...

tested and working well.

Log in or register to post comments

Comment #2

hunmonk CreditAttribution: hunmonk commented 14 March 2006 at 16:55

File	Size
fb_0.patch	1.19 KB

added a few code comments to the patch for clarity.

Log in or register to post comments

Comment #3

hunmonk CreditAttribution: hunmonk commented 14 March 2006 at 17:06

Title:

form_builder checkbox stuff

» form_builder checkbox/textfield/validation stuff

Log in or register to post comments

Comment #4

dopry CreditAttribution: dopry commented 14 March 2006 at 22:27

re: fb_0.patch in comment #2.

+1, code looks to fit the coding standards...
Tested by using the project module from CVS.

Created a demo project, enabled issue tracking.

Created a new issue. On the second page of the issue form I was immediately greeted with validation errors.

Applied patch

Creating an issue proceeded without the validation errors.

.darrel.

Log in or register to post comments

Comment #5

chx CreditAttribution: chx commented 15 March 2006 at 05:34

Status:

Needs review

» Reviewed & tested by the community

File	Size
fb_1.patch	1.22 KB

$a = $b = foo is not really used anywhere in Drupal. I broke that into two lines. Otherwise, it's the same.

If someone would post some instructions on setting up project that would be a great addition because then I could join the project testers.

Log in or register to post comments

Comment #6

dopry CreditAttribution: dopry commented 15 March 2006 at 07:03

install project module...(enable, has a proper .install so you shouldn't need to futz with mysql).
admin/settings/project -> add a term to two to the projects vocab.
create content ->project (enable issue tracking)...
create contect-> issue.....