In the spirit of #263956: Ye Grande Olde Drupal 7 .install File Cleanup, this breaks up the work a bit since the original issue is a huge bite to try to tackle in one patch. This patch moves the functions around in menu.install to put the functions in order of schema, install, uninstall. No code was changed - only the order of the functions.

CommentFileSizeAuthor
#6 menu_install_cleanup.patch3.13 KBlambic
#3 menu_install_cleanup.patch3.21 KBlambic
menu_install_cleanup.patch3.4 KBdeekayen
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

boombatower’s picture

boombatower CreditAttribution: boombatower commented
Status: Needs review » Reviewed & tested by the community

Looks good.

Status: Reviewed & tested by the community » Needs work

The last submitted patch failed testing.

lambic’s picture

lambic CreditAttribution: lambic commented
Status: Needs work » Needs review
FileSize
menu_install_cleanup.patch3.21 KB

maybe the bot will like this one better

andypost’s picture

andypost
he/him
Primary language Russian
CreditAttribution: andypost commented
Status: Needs review » Reviewed & tested by the community

looks good

Status: Reviewed & tested by the community » Needs work

The last submitted patch failed testing.

lambic’s picture

lambic CreditAttribution: lambic commented
FileSize
menu_install_cleanup.patch3.13 KB

rerolled patch

lambic’s picture

lambic CreditAttribution: lambic commented
Status: Needs work » Needs review
andypost’s picture

andypost
he/him
Primary language Russian
CreditAttribution: andypost commented
Status: Needs review » Reviewed & tested by the community

back to rtbc again

Dries’s picture

Dries CreditAttribution: Dries commented
Status: Reviewed & tested by the community » Fixed

Committed to CVS HEAD.

Status: Fixed » Closed (fixed)
Issue tags: -Novice

Automatically closed -- issue fixed for 2 weeks with no activity.

Issue tags: +Novice

Restoring issue tags, see #2125755: System messages removed all issue tags during D7 upgrade.